From: Tomi Ollila <tomi.ollila@iki.fi>
To: Ian Main <imain@stemwinder.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] VIM: Make an option to save sent mail locally
In-Reply-To: <5433693499518_7e54e45e9424@ovo.mains.priv.notmuch>
References: <1412617904-27252-1-git-send-email-imain@stemwinder.org>
	<1412619036-29203-1-git-send-email-imain@stemwinder.org>
	<m27g0dt5lk.fsf@guru.guru-group.fi>
	<5433693499518_7e54e45e9424@ovo.mains.priv.notmuch>
User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Sun, 19 Oct 2014 12:53:19 +0300
Message-ID: <m2mw8sbd2o.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Tue, Oct 07 2014, Ian Main <imain@stemwinder.org> wrote:

> Tomi Ollila wrote:
>> On Mon, Oct 06 2014, Ian Main <imain@stemwinder.org> wrote:
>> 
>> > Add an option to use 'notmuch insert' to save your sent mail.
>> > ---
>> >
>> > Add -inbox as well.
>> >
>> >  vim/notmuch.vim | 17 +++++++++++++++++
>> >  1 file changed, 17 insertions(+)
>> >
>> > diff --git a/vim/notmuch.vim b/vim/notmuch.vim
>> > index 331e930..a9044c4 100644
>> > --- a/vim/notmuch.vim
>> > +++ b/vim/notmuch.vim
>> > @@ -58,6 +58,7 @@ let s:notmuch_date_format_default = '%d.%m.%y'
>> >  let s:notmuch_datetime_format_default = '%d.%m.%y %H:%M:%S'
>> >  let s:notmuch_reader_default = 'mutt -f %s'
>> >  let s:notmuch_sendmail_default = 'sendmail'
>> > +let s:notmuch_save_sent_locally_default = 1
>> >  let s:notmuch_folders_count_threads_default = 0
>> >  
>> >  function! s:new_file_buffer(type, fname)
>> > @@ -108,6 +109,18 @@ EOF
>> >  		echohl None
>> >  		return
>> >  	endif
>> 
>> AFAIU looks mmm. readable ;)
>> 
>> > +
>> > +	if g:notmuch_save_sent_locally
>> > +		let out = system('cat ' . fname . ' | notmuch insert --create-folder --folder=Sent +sent -unread -inbox')
>> 
>> as this is (looks like) shell invocation, this could be in format
>> 
>> let out = system('notmuch insert --create-folder --folder=Sent +sent -unread -inbox < ' . fname)
>
> You are right, that's better.
>
>> or even 
>> 
>> let out = system('exec notmuch insert --create-folder --folder=Sent +sent -unread -inbox < ' . fname)
>> 
>> (well, the latter would be out of the status quo)
>> 
>> Ok, I looked a bit into the notmuch.vim -code, and noticed sometimes
>> system() command lines use "notmuch" and sometimes g:notmuch_cmd 
>> -- I think the latter should be used in new code and the previous ones
>> should be fixed.
>> 
>> i.e. system ( g:notmuch_cmd . ' insert ... ' < . fname)
>> 
>> Totally untested from my part...
>> 
>> When the change alike this lands to the notmuch repository this needs NEWS
>> item which informs that from now sent mails are notmuch-inserted to
>> user's mail store (as this seems to be the default...) -- well, let's see
>> that when there are real reviewers (i.e. those who are interested to and can
>> test this).
>
> Also a good suggestion.  From what I see they always use 'notmuch' straight up
> which is probably a reasonable assumption.  I do think the actual init code for
> vim could have a few more checks, such as verifying that 'notmuch' is in $PATH
> etc. 
>
> Thanks for the review!!  I'll send out a new rev tomorrow - very tired
> right now.

I never seen the new rev... :D

>
>     Ian

Tomi