From: Mark Walters <markwalters1009@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/2] Allow forwarding of all open messages in the
 current view.
In-Reply-To: <1454792877-7180-1-git-send-email-dme@dme.org>
References: <1454792877-7180-1-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.18.1+485~gca076ce (http://notmuchmail.org) Emacs/24.4.1
 (x86_64-pc-linux-gnu)
Date: Sun, 07 Feb 2016 23:57:18 +0000
Message-ID: <87y4awm5up.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list


On Sat, 06 Feb 2016, David Edmondson <dme@dme.org> wrote:
> Allow forwarding of all open messages in the current view.
>
> In response to id:"87fvyhb40x.fsf@alice.fifthhorseman.net".
>
> v2:
> - Use multiple message forwarding to implement single message
>   forwarding.
>

This basically looks good to me. At the moment there is some typo in the
first patch introducing two extra parenthesis at the end of the 
notmuch-mua-new-forward-messages function.

I checked with both message-forward-as-mime true (default giving rfc822
parts) and set to nil (including the messages as plain text) and both
looked as I would expect.

Finally, with this in place it would be very easy to introduce thread
forwarding from search mode. But that can be left until after this.

Best wishes

Mark


>
> David Edmondson (2):
>   emacs: Add `notmuch-show-forward-open-messages'.
>   emacs: `notmuch-show-forward-message' can use
>     `notmuch-mua-new-forward-messages'
>
>  emacs/notmuch-mua.el  | 62 +++++++++++++++++++++++++++++++++++++--------------
>  emacs/notmuch-show.el | 15 +++++++++++--
>  2 files changed, 58 insertions(+), 19 deletions(-)
>
> -- 
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch