From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/1] lib/message-file.c: use g_malloc () & g_free () in
	hash table values
In-Reply-To: <1356112321-6332-1-git-send-email-tomi.ollila@iki.fi>
References: <1356112321-6332-1-git-send-email-tomi.ollila@iki.fi>
User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-pc-linux-gnu)
Date: Sat, 22 Dec 2012 09:21:40 -0400
Message-ID: <87sj6yte6z.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam_bar: -
Cc: tomi.ollila@iki.fi
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Dec 2012 13:21:52 -0000

Tomi Ollila <tomi.ollila@iki.fi> writes:

> @@ -111,7 +111,7 @@ _notmuch_message_file_open_ctx (void *ctx, const char *filename)
>      message->headers = g_hash_table_new_full (strcase_hash,
>  					      strcase_equal,
>  					      free,
> -					      free);
> +					      g_free);

It slightly icky that the keys in this hash table are allocated/freed
with (x)malloc/(x)free, and the values with g_malloc/g_free, but that's
not your fault, and it's an improvement on what we had before, so +1
from me.

d