Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7A4F340D168 for ; Thu, 4 Nov 2010 12:39:14 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.89 X-Spam-Level: X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6a6UK9HeDd-1; Thu, 4 Nov 2010 12:39:02 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7BC1740D158; Thu, 4 Nov 2010 12:39:02 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id CE982254102; Thu, 4 Nov 2010 12:39:01 -0700 (PDT) From: Carl Worth To: Michal Sojka , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] test: Search for non-existent message should return nothing In-Reply-To: <1288628140-15410-1-git-send-email-sojkam1@fel.cvut.cz> References: <1288628140-15410-1-git-send-email-sojkam1@fel.cvut.cz> User-Agent: Notmuch/0.4 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Thu, 04 Nov 2010 12:39:01 -0700 Message-ID: <87vd4cq3oq.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2010 19:39:14 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 1 Nov 2010 17:15:39 +0100, Michal Sojka wrot= e: > My scripts expect that empty search result is actually empty. Since > commit 6dcb7592, even empty search prints a newline character and this > breaks my scripts. Thanks for this fix, Michal. I get to apologize doubly on this one. First, I'm sorry that I was greedy and tried to factor out some common code, not realizing the bug I introduced in the process. Second, I'm sorry I didn't get your fix into the 0.4 release, (since I think you did send it before I wrapped that up). I've at least pushed your fix now. Thanks especially for including a new test (and fix!) with your bug report. That's hugely appreciated. =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFM0wvV6JDdNq8qSWgRAiVoAJ9IGAMRk388VZ0uPfVwLOGodpq21ACfb8mG 1DkcU3HKeigbAFgGHfstzkQ= =bivo -----END PGP SIGNATURE----- --=-=-=--