Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1AE19431FB6 for ; Sat, 25 Jan 2014 00:41:39 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.098 X-Spam-Level: X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z0MsL1vFKd6d for ; Sat, 25 Jan 2014 00:41:31 -0800 (PST) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id D07BE431FBC for ; Sat, 25 Jan 2014 00:41:30 -0800 (PST) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1W6yno-0005pO-7d; Sat, 25 Jan 2014 08:41:22 +0000 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) (envelope-from ) id 1W6ymu-0006pO-Sd; Sat, 25 Jan 2014 08:40:25 +0000 From: Mark Walters To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH 0/7] cli: notmuch new improvements In-Reply-To: References: User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Sat, 25 Jan 2014 08:38:59 +0000 Message-ID: <87ppnga21o.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 93.97.24.31 X-QM-Geographic: According to ripencc, this message was delivered by a machine in Britain (UK) (GB). X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: 550d19702d099cd9b0ad9441b7d84148 (of first 20000 bytes) X-SpamAssassin-Score: 0.0 X-SpamAssassin-SpamBar: / X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored 0.0 points. Summary of the scoring: * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * 0.0 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jan 2014 08:41:39 -0000 This series LGTM. I do now recall there was some discussion on irc about the automatic database upgrade: it would be good to have that documented but the consensus was to do it, so +1 from me. Best wishes Mark On Sun, 19 Jan 2014, Jani Nikula wrote: > Here's an assortment of notmuch new fixes, non-functional cleanups, and > the oft-requested --quiet option. > > These should be pretty straightforward to review. > > BR, > Jani. > > > Jani Nikula (7): > cli: extract single message addition in notmuch new to clarify code > cli: only check the ignore list if needed > cli: use dirent_type in count_files too > cli: for loop is more customary > cli: abstract notmuch new result printing > cli: add --quiet option to notmuch new > man: document notmuch new --quiet option > > man/man1/notmuch-new.1 | 5 + > notmuch-new.c | 253 ++++++++++++++++++++++++++----------------------- > 2 files changed, 137 insertions(+), 121 deletions(-) > > -- > 1.8.5.2 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch