Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1B4F6431FC2 for ; Wed, 29 Oct 2014 06:32:27 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tq4gAlkFfe69 for ; Wed, 29 Oct 2014 06:32:19 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 999B7431FB6 for ; Wed, 29 Oct 2014 06:32:19 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id A4F88100051; Wed, 29 Oct 2014 15:32:03 +0200 (EET) From: Tomi Ollila To: Jesse Rosenthal , Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH] Avoid empty thread names if possible. In-Reply-To: <87a94f2fe3.fsf@jhu.edu> References: <87oatnakqy.fsf@jhu.edu> <87tx2nuvec.fsf@qmul.ac.uk> <87a94f2fe3.fsf@jhu.edu> User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Oct 2014 13:32:27 -0000 On Wed, Oct 29 2014, Jesse Rosenthal wrote: > By the way, this discussion brings up another problem. I wasn't able to > write a test for this (to address the below concerns) because the test > suite for thread-naming supplies some sort of auto-generated subject > for threads with empty subjects. So we can't test behavior for dealing > with empty subjects. > > Unfortunately, I don't know the history of the test suite, or why this > auto-subject decisicion was made, so I don't feel comfortable just > changing the behavior. Autogeneration of (unique) headers when some header not given... Shell could distinguish between unset and empty variable, but that would proably make most users feel PITA to use it... (*) ... probably better altelnative could be some magic word, like 'none' to make generate_message() set header in question empty (and first just implement that "feature" to Subject header. Tomi (*) personally I'd be totally comfortable with it, though ;D