Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3ACC14196F3 for ; Thu, 22 Apr 2010 15:17:39 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -4.2 X-Spam-Level: X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4iF0HECpDwh9 for ; Thu, 22 Apr 2010 15:17:38 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by olra.theworths.org (Postfix) with ESMTP id 721564196F2 for ; Thu, 22 Apr 2010 15:17:38 -0700 (PDT) Received: from localhost ([::1] helo=x200.gr8dns.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1O54iH-00078L-S3; Thu, 22 Apr 2010 22:17:38 +0000 Received: by x200.gr8dns.org (Postfix, from userid 500) id 13D20C0247; Thu, 22 Apr 2010 15:17:37 -0700 (PDT) From: Dirk Hohndel To: Carl Worth , notmuch@notmuchmail.org Subject: Re: [PATCH] Add 'G' keybinding to folder and search view that triggers external poll In-Reply-To: <874oj3gnrq.fsf@yoom.home.cworth.org> References: <874oj3gnrq.fsf@yoom.home.cworth.org> Date: Thu, 22 Apr 2010 15:17:37 -0700 Message-ID: User-Agent: notmuch 0.2-52-ga28d2fe (Emacs 23.1.1/i386-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2010 22:17:39 -0000 On Thu, 22 Apr 2010 14:50:33 -0700, Carl Worth wrote: > On Fri, 09 Apr 2010 12:53:26 -0700, Dirk Hohndel wrote: > > The new functions first check if an external poll script has been defined in > > the variable 'notmuch-external-refresh-script and if yes, runs that script > > before executing the existing refresh function (which is bound to '=') > > Thanks Dirk, > > This is even handier than I expected. > > I've pushed this now, but followed up immediately with a (totally > trivial) change to reduce code duplication, and then a (slightly more > major) change to define the controlling variable with defcustom so that > the user can find the variable in the customize screen for notmuch. > > I also renamed it to notmuch-poll-script so you'll need to update your > setting for this feature to work. I appreciate how nicely you can say "I liked the idea and then completely rewrote the crap elisp that you submitted" :-) /D -- Dirk Hohndel Intel Open Source Technology Center