Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6B0A9431FBF for ; Fri, 3 Oct 2014 01:48:29 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kDRhl7zuw4Mu for ; Fri, 3 Oct 2014 01:48:24 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id ABFC0431FB6 for ; Fri, 3 Oct 2014 01:48:24 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1XZyXH-0005nG-9C; Fri, 03 Oct 2014 05:48:23 -0300 Received: (nullmailer pid 17015 invoked by uid 1000); Fri, 03 Oct 2014 08:48:13 -0000 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v4] lib: Simplify close and codify aborting atomic section In-Reply-To: <1412277548-3445-1-git-send-email-aclements@csail.mit.edu> References: <87mw9ee0vf.fsf@csail.mit.edu> <1412277548-3445-1-git-send-email-aclements@csail.mit.edu> User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Fri, 03 Oct 2014 10:48:13 +0200 Message-ID: <87oattr12q.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Oct 2014 08:48:29 -0000 Austin Clements writes: > This patch simplifies notmuch_database_close to explicitly abort any > outstanding transaction and then just call Database::close. This > works for both read-only and read/write databases, takes care of > committing changes, unifies the exception handling path, and codifies > aborting outstanding transactions. This is currently the only way to > abort an atomic section (and may remain so, since it would be > difficult to roll back things we may have cached from rolled-back > modifications). pushed d