Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2ACA1431FB6 for ; Fri, 3 Jun 2011 14:26:59 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RvM+oTAlGcYx for ; Fri, 3 Jun 2011 14:26:57 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 28C9B431FD0 for ; Fri, 3 Jun 2011 14:26:57 -0700 (PDT) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id 7DCF6328196; Fri, 3 Jun 2011 14:20:01 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from servo.finestructure.net (gwave-79.ligo.caltech.edu [131.215.114.79]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id 5026A328203; Fri, 3 Jun 2011 14:19:58 -0700 (PDT) Received: by servo.finestructure.net (Postfix, from userid 1000) id 4FF01AD6; Fri, 3 Jun 2011 14:26:51 -0700 (PDT) From: Jameson Graef Rollins To: Carl Worth , Notmuch Mail Subject: Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text In-Reply-To: <87r57almd9.fsf@yoom.home.cworth.org> References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net> <1306619520-25730-2-git-send-email-jrollins@finestructure.net> <1306619520-25730-3-git-send-email-jrollins@finestructure.net> <1306619520-25730-4-git-send-email-jrollins@finestructure.net> <1306619520-25730-5-git-send-email-jrollins@finestructure.net> <1306619520-25730-6-git-send-email-jrollins@finestructure.net> <1306619520-25730-7-git-send-email-jrollins@finestructure.net> <1306619520-25730-8-git-send-email-jrollins@finestructure.net> <1306619520-25730-9-git-send-email-jrollins@finestructure.net> <1306619520-25730-10-git-send-email-jrollins@finestructure.net> <1306619520-25730-11-git-send-email-jrollins@finestructure.net> <1306619520-25730-12-git-send-email-jrollins@finestructure.net> <1306619520-25730-13-git-send-email-jrollins@finestructure.net> <1306619520-25730-14-git-send-email-jrollins@finestructure.net> <1306619520-25730-15-git-send-email-jrollins@finestructure.net> <1306619520-25730-16-git-se nd-email-jrollins@finestructure.net> <1306619520-25730-17-git-send-email-jrollins@finestructure.net> <1306619520-25730-18-git-send-email-jrollins@finestructure.net> <1306619520-25730-19-git-send-email-jrollins@finestructure.net> <1306619520-25730-20-git-send-email-jrollins@finestructure.net> <1306619520-25730-21-git-send-email-jrollins@finestructure.net> <1306619520-25730-22-git-send-email-jrollins@finestructure.net> <1306619520-25730-23-git-send-email-jrollins@finestructure.net> <1306619520-25730-24-git-send-email-jrollins@finestructure.net> <1306619520-25730-25-git-send-email-jrollins@finestructure.net> <1306619520-25730-26-git-send-email-jrollins@finestructure.net> <87r57almd9.fsf@yoom.home.cworth.org> User-Agent: Notmuch/0.6 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 03 Jun 2011 14:26:48 -0700 Message-ID: <87lixihahz.fsf@servo.factory.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2011 21:26:59 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 03 Jun 2011 12:56:50 -0700, Carl Worth wrote: > On Sat, 28 May 2011 14:52:00 -0700, Jameson Graef Rollins wrote: > > The declaration of the GMimeStream pointer to stdout in > > format_part_content_text was somehow preventing subsequent printf > > calls from outputting to stdout if the output was redirected to a > > file. Scoping the declaration to the actual use of the stream pointer > > works around this problem. >=20 > This commit message sounds like we don't actually understand the problem > being fixed here. Well actually it's only meant to sound like the committer doesn't understand the problem! > I'd like to investigate this more. Perhaps with a test case? The current tests are how I found the problem! Without this patch at least the multipart tests will fail. I don't see how another test will add anything. Carl, if you (or anyone else) understands what the issue is, then please go ahead and modify the commit message. I don't understand things enough myself to do any better. Clearly there is some strange interaction with things that try to use stdout after g_mime_stream_file_new() has already grabbed it. I really wouldn't block on this, though, since the patch does fix an actual bug. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJN6VGZAAoJEO00zqvie6q8fJEP/2LacoimwdTtHAplFv9/xcv5 r+TBiPu9yCNxbzmknYFPnYE2Lj2XzHZ+eEUyA+NTFYEdAekO6k8WbHrDCHrtcU7c mgqhjGByS+9VAxnb92bBkkBRNOJhRSsJDngnjPmFTzLCDDh1sp1cW3yy3tNzx0ha 5e9n4p7QicCRdRsyd4ZVRWeTITzCUmgZaN/XJPcm0cDK7i0+PFVz1HchRAHEevjk /Am5i5vAHE1g7i6pPMxCP92bpJ7Btu200TPzcc+SoO3sUXWL5HrW1tcrWSmhtqFk MLCbF/fhDe0JdjpSiZjAmIFcQ7FjauodmIztusAk4vNJm5GtIZWZU+wPEHmKu31d gaTUxwmVtFNtrDz4al/jCtyvts/uOfCoahDAU1qZ9TLzdBnfyIHxATBvBjssjVqU eu3p8e5BR6a3+o8urxKUmy2iDycPA+LYQyLObgUtNycCWKv/BkF5Hswv1rJnFVkQ WxVG0jtoHupkbC/zRUar4bbRWk6RGhYQed4AJFs909GsyJd1BfLjcNsKexnGfQen DCbwz23nkJ24hosNuIeXLr7WIEvPh/Hr8rT7dSGdYEogU28Qq6fuaoEg6B5CYMDq H6oeqDEV4GlNNDhHXrf5XZx2Qw/oGQjBHYnsLfkaG1gCyg5cWCDinpZb0XBENtwv pDAb7l2NxUKj+vyiJ7sM =re27 -----END PGP SIGNATURE----- --=-=-=--