Return-Path: <blakej@foo.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 3A231431FC0
	for <notmuch@notmuchmail.org>; Mon,  5 Nov 2012 10:36:14 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id f8-G5VSUuj9Q for <notmuch@notmuchmail.org>;
	Mon,  5 Nov 2012 10:36:13 -0800 (PST)
Received: from foo.net (70-36-235-136.dsl.static.sonic.net [70.36.235.136])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id BB3A3431FAE
	for <notmuch@notmuchmail.org>; Mon,  5 Nov 2012 10:36:13 -0800 (PST)
Received: from foo.net (localhost [127.0.0.1])
	by foo.net (8.14.5+Sun/8.14.5) with ESMTP id qA5Ia8SG010910;
	Mon, 5 Nov 2012 10:36:08 -0800 (PST)
To: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH 00/10] Solaris support 
In-Reply-To: Your message of "Mon, 05 Nov 2012 19:43:08 +0200."
	<m2fw4oeyj7.fsf@guru.guru-group.fi> 
Date: Mon, 05 Nov 2012 10:36:08 -0800
Message-ID: <10909.1352140568@foo.net>
From: Blake Jones <blakej@foo.net>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2
	(foo.net [127.0.0.1]); Mon, 05 Nov 2012 10:36:08 -0800 (PST)
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Nov 2012 18:36:14 -0000

> Just now I don't have more time to comment and review more, but in the
> first 2/3 patches when I tried to compile I got problem NULL not
> defined.

Oh!  Yes, I should include <stdio.h> to pull in the definition of NULL.
I'll fix that.

> Another thing: you have this
> 
>  +# Whether the asctime_r function is standards-compliant
>  +# (if not, then notmuch will compile with -D_POSIX_PTHREAD_SEMANTICS
>  +# to enable the standards-compliant version -- needed for Solaris)
> 
> which is not exactly so.. you added the following lines in compat.h
> 
>  +#if !STD_GETPWUID
>  +#define _POSIX_PTHREAD_SEMANTICS
>  +#endif
> 
> which is slightly different as -D_POSIX_PTHREAD_SEMANTICS is equivalent to 
> #define _POSIX_PTHREAD_SEMANTICS 1
> 
> (you probably knew this and your comments have drifted from actual
> implementation but just to make sure)

I'll make the code and comment line up better.

Thanks for your comments.

Blake