Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id B46B56DE1817 for ; Mon, 26 Oct 2015 11:56:59 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -8.929 X-Spam-Level: X-Spam-Status: No, score=-8.929 tagged_above=-999 required=5 tests=[AM.WBL=-8, ALL_TRUSTED=-1, AWL=0.071] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f8Kl_-rWHseZ; Mon, 26 Oct 2015 11:56:58 -0700 (PDT) Received: from wondoo.home.cworth.org (unknown [10.0.0.1]) (Authenticated sender: cworth) by arlo.cworth.org (Postfix) with ESMTPSA id 1B6456DE17E6; Mon, 26 Oct 2015 11:56:58 -0700 (PDT) Received: from wondoo.home.cworth.org (localhost [IPv6:::1]) by wondoo.home.cworth.org (Postfix) with ESMTPS id 0AC5B14C492B; Mon, 26 Oct 2015 11:56:58 -0700 (PDT) To: Tomi Ollila , David Bremner , notmuch@notmuchmail.org Subject: Re: elisp + company completion patches, v7 In-Reply-To: References: <1445786638-13763-1-git-send-email-david@tethera.net> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Sender: cworth@cworth.org From: Carl Worth Date: Mon, 26 Oct 2015 11:56:56 -0700 Message-ID: <871tche9vr.fsf@wondoo.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2015 18:56:59 -0000 --=-=-= Content-Type: text/plain On Sun, Oct 25 2015, Tomi Ollila wrote: > I, if this does not sound nitpicking, would amend those 'This patch' and > 'With this patch' texts in commit messages away by some rewording -- those > pose as a bad example for someone reading the code -- and diminish the > effect when I complain that again in future patched ;) What's the motivation here? It's often the case that a good commit message needs to describe the way things were working prior to a commit, (describing the bug or missing feature or what have you), and also needs to describe the change that is affected by the commit itself. So I actually like seeing commit messages that say things like: Prior to this commit... (some bug existed...) In this commit... (some code is reworked to fix the bug...) But maybe I've missed the point of your message. -Carl --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJWLnd5AAoJEGACM7qeVNxh9pwQAKVp3EqS3EgE+3PvWWRSzh1W 4MNyIZoinupCnZ1eulrvUYi9O+a1w0F/O7vYcfcw68K7nFCYAInhHJpX6YUwHqW0 SXO16TOnpPCqjdvPxgKDSAoyviWuNc0CwW0bqVdA31N3Y+0eRP4KYJgYPyxU9XhK 48uGJlHlRHwiOSHRvQzOAB+iOEOyy88Q6VJlaZLRwAQB//En/TQnLHBWxxkM1aO6 +XqHqlrM02KhPMQXP8BduY+/7sZQYUZv1QHgV+RjbD8JVAuKW7ir4SGc71XtnbY+ icB9/NCC3cs2+wtSC40K13TE7pymC6OSfK40By52fjrpTsd8IFe0rt6uqYWfprdx N4jzcxBpvvzSJrAQlK80Ko94uTjDVmSO/JlQ289wyBvkxHBZSKr9xCgEHHFXbRnh sctVIABkNfAP1e38Zsz7bnlPPhPRABUXjurKK/IEblt/KFEVBF2d/JmlCj8UKb0n Y+Emgbh4UXBQigpDKYGSfxoOnflh+0dZL4NdNVy4b43gg2SznmxApMEnyHO4j76z ZYNcSxQxaWjzjmP45qr3L0wE/rsoHcEXL3i3WP9DnwziKRi3fC0g/rKM3+4mYsUw UflzJYDeSb609EEX8M/cpBqWiDGhssWHcHSIX6ex/P5Iqj687sOAGt9kXG2uo1fa 3rv6vItEo7+lFDcS/FVr =D39h -----END PGP SIGNATURE----- --=-=-=--