From: Aaron Ecay <aaronecay@gmail.com>
To: David Edmondson <dme@dme.org>, Pieter Praet <pieter@praet.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Don't attempt to colour tags in
	`notmuch-show-mode'.
In-Reply-To: <cunmx9n51u4.fsf@hotblack-desiato.hh.sledj.net>
References: <1325004434-24583-1-git-send-email-dme@dme.org>
	<87aa5nlwwg.fsf@praet.org>
	<cunmx9n51u4.fsf@hotblack-desiato.hh.sledj.net>
User-Agent: Notmuch/0.11+62~ge41b0d3 (http://notmuchmail.org) Emacs/24.0.92.1
	(i386-apple-darwin10.8.0)
Date: Mon, 16 Jan 2012 15:51:30 -0500
Message-ID: <m2zkdnbcbx.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Mon, 16 Jan 2012 11:22:27 +0000, David Edmondson <dme@dme.org> wrote:
> On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet <pieter@praet.org> wrote:
> > Alas, those text properties actually *were* effective (and I liked them=
 :)
>=20
> Well, not in emacs 24. My reading of the source was that overlays were
> intended to stomp on text properties, but that could have been wrong.
>=20
> Do they look correct when you add/remove tags?

The tags look nice and yellow-green for me too on a trunk build of emacs
(which is one flavor of emacs 24).  Adding and removing tags works as
expected =E2=80=93 the tags dis/appear and are the right color.

I haven=E2=80=99t reloaded the notmuch *.el files since this change landed,=
 but
I agree with Pieter that the overlays were nice.

--=20
Aaron Ecay