From: Jani Nikula <jani@nikula.org>
To: Tomi Ollila <tomi.ollila@iki.fi>, Austin Clements <amdragon@MIT.EDU>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH v2] test: Canonicalize RFC 2047 encoding and charset
In-Reply-To: <m2txil3fng.fsf@guru.guru-group.fi>
References: <m238q698na.fsf@guru.guru-group.fi>
	<1376923203-14406-1-git-send-email-amdragon@mit.edu>
	<m2txil3fng.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.16+10~g791e68f (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 19 Aug 2013 18:13:50 +0300
Message-ID: <871u5pbtn5.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Mon, 19 Aug 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Mon, Aug 19 2013, Austin Clements <amdragon@MIT.EDU> wrote:
>
>> RFC 2047 states that the encoding and charset in an encoded word are
>> case-insensitive, so force them to lower case in the reply test.  This
>> fixes an issue caused by GMime versions (somewhere between 2.6.10 and
>> 2.6.16), which changed the capitalization of the encoding.
>> ---
>>  test/reply |    8 +++++---
>>  1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/test/reply b/test/reply
>> index d4389cf..b0d854a 100755
>> --- a/test/reply
>> +++ b/test/reply
>> @@ -201,12 +201,14 @@ add_message '[subject]="=?iso-8859-1?q?=e0=df=e7?="' \
>>  	    '[date]="Tue, 05 Jan 2010 15:43:56 -0000"' \
>>  	    '[body]="Encoding"'
>>  
>> -output=$(notmuch reply id:${gen_msg_id})
>> -# Note that GMime changes from Q- to B-encoding
>> +# GMime happens to change from Q- to B-encoding.  We canonicalize the
>> +# case of the encoding and charset because different versions of GMime
>> +# capitalize the encoding differently.
>> +output=$(notmuch reply id:${gen_msg_id} | perl -pe 's/=\?[^?]+\?[bB]\?/lc($&)/ge')
>
> LGTM.

And the relevant test passes with this version too.

Jani.