Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7A6EF431FBD for ; Sun, 25 Jan 2015 06:29:05 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 2.438 X-Spam-Level: ** X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m-8DRJf+YFgr for ; Sun, 25 Jan 2015 06:28:59 -0800 (PST) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id F0285431FB6 for ; Sun, 25 Jan 2015 06:28:58 -0800 (PST) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 0389D100033; Sun, 25 Jan 2015 16:28:32 +0200 (EET) From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] doc: gzipped notmuch.3 before trying to install notmuch.3.gz In-Reply-To: <1422194858-19490-1-git-send-email-david@tethera.net> References: <1421963721-17106-1-git-send-email-tomi.ollila@iki.fi> <1422194858-19490-1-git-send-email-david@tethera.net> User-Agent: Notmuch/0.19+29~g7367d27 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Jan 2015 14:29:07 -0000 On Sun, Jan 25 2015, David Bremner wrote: > If HAVE_SPHINX=0 but HAVE_DOXYGEN=1, then the previous version was > trying to install notmuch.3.gz but only got as far as creating > notmuch.3 > --- > > doc/Makefile.local is messy enough that I found Tomi's fix hard to > follow. Probably the real answer is to fix some of this mess, but in the > mean time, what about this as an alternative fix? Sure looks simpler - I also couldn't figure out (just by quickly looking my patch) how that exactly made things work... This alternative fix is IMO good for the time being, and fixes a real problem. I wonder whether gzipped user docs are created at build time but gzipped apidocs just before install -- I might spare more time checking that when on my regular linux desktop (these alternatives are just too PITA to use ;) Tomi > > doc/Makefile.local | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/Makefile.local b/doc/Makefile.local > index 0bdf2e1..e209749 100644 > --- a/doc/Makefile.local > +++ b/doc/Makefile.local > @@ -60,7 +60,7 @@ install-man: install-apidocs > ifeq ($(HAVE_DOXYGEN),1) > MAN_GZIP_FILES += ${APIMAN}.gz > apidocs: $(APIMAN) > -install-apidocs: apidocs > +install-apidocs: ${APIMAN}.gz > mkdir -p "$(DESTDIR)$(mandir)/man3" > install -m0644 $(DOCBUILDDIR)/man/man3/*.3.gz $(DESTDIR)/$(mandir)/man3 > > -- > 2.1.4