Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 3A1AE6DE0924 for ; Sat, 26 Sep 2015 02:00:21 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.156 X-Spam-Level: X-Spam-Status: No, score=-0.156 tagged_above=-999 required=5 tests=[AWL=-0.180, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jYjrFTGw4sGC for ; Sat, 26 Sep 2015 02:00:18 -0700 (PDT) Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by arlo.cworth.org (Postfix) with ESMTPS id 708736DE01F5 for ; Sat, 26 Sep 2015 02:00:18 -0700 (PDT) Received: by wicfx3 with SMTP id fx3so48146915wic.1 for ; Sat, 26 Sep 2015 02:00:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type; bh=6Mmf1tmPrpKB/JPGZ1gCPp77GNSnAwxJRyu8c7MEU6A=; b=OV8FEQGd88WwT43PSTxVGthl/lVD30b7hwOjlTnR1nYC0Gp6gUDi/8AdbO3iNuS+dx DrloF0xi13sbmzaHx27t9aJEZ56xpyliVRIf/CU3RCRf/R1BNv3Po91oZv9qKhMdA2Cj zctuCIjVUKBl9LzGykwXzdXpuS8KL6efB2zn9L/I2CeNwx+H83kmBxjk5vJteBP7mIJu I8ucEA3oQc1oRYuYbBsDQ53u8MMa0au7+D6GoKaO6zOoOVUYkAJzeoLnW28gzby5OA4X Be2mPRq/jix4zduIQKE30nyHwKtLRVa0h9oXdiNJHlXD1t03Fym/W0lVlKD0yBmcnwMj kobQ== X-Gm-Message-State: ALoCoQn6m5AoR5hWaNGNOc61Sr+HFZw/rxDqffGp3lMT6hgzkseCjsZ2lHs/0HO0fvfaYt6pExb+ X-Received: by 10.180.11.175 with SMTP id r15mr8173167wib.74.1443258016784; Sat, 26 Sep 2015 02:00:16 -0700 (PDT) Received: from localhost (mobile-access-bcee63-221.dhcp.inet.fi. [188.238.99.221]) by smtp.gmail.com with ESMTPSA id go5sm7340003wib.3.2015.09.26.02.00.15 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 26 Sep 2015 02:00:16 -0700 (PDT) From: Jani Nikula To: David Bremner , Johannes Schauer , notmuch@notmuchmail.org Subject: Re: [bug] notmuch requires Content-Disposition mime header value to be lower case In-Reply-To: <871tdvvoyf.fsf@tesseract.cs.unb.ca> References: <20150917070056.1941.94846@localhost> <20150917083612.1941.22480@localhost> <20150917083956.1941.35098@localhost> <87pp1grl2v.fsf@maritornes.cs.unb.ca> <20150918123724.1941.3900@localhost> <871tdvvoyf.fsf@tesseract.cs.unb.ca> User-Agent: Notmuch/0.20.2+66~gb33abd9 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Sat, 26 Sep 2015 11:59:58 +0300 Message-ID: <87eghlmu7l.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Sep 2015 09:00:21 -0000 On Fri, 18 Sep 2015, David Bremner wrote: > Johannes Schauer writes: > >> Hi, >> >> Quoting David Bremner (2015-09-18 14:03:20) >>> I'd recommend making your own new test, rather than modifying existing >>> ones to test multiple things. I'd also recommend using json / sexp >>> output for your tests, since the ad-hoc text format is kindof >>> semi-deprecated. >> >> can you take care of that? My goal was actually just to report this bug, not to >> spend more time to develop a proper patch for it :) > > Consider the bug reported. At the moment I'm not completely convinced > the patch is correct, never mind the tests. I agree it looks obvious > enough, but the test results don't make sense to me yet. > >> >> Also, a related problem occurs when the Content-Disposition header contains >> UTF8 characters, in which case the header value gets encoded. Apparently >> notmuch does not attempt to decode it. Example mime header: >> >> --===============7161366892858136962== >> Content-Type: application/pdf >> MIME-Version: 1.0 >> Content-Transfer-Encoding: base64 >> Content-Disposition: =?utf-8?b?YXR0YWNobWVudDsgZmlsZW5hbWU9ImJlZ3LDvMOfdW5n?= >> =?utf-8?b?LnBkZiI=?= > > yes, that sounds like a distinct bug. ...in the sending end. Correct me if you think I'm wrong, but I don't think that kind of encoding is allowed in Content-Disposition. BR, Jani. > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch