Date: Wed, 13 Jul 2011 01:03:16 -0400
From: Austin Clements <amdragon@MIT.EDU>
To: Istvan Marko <notmuch@kismala.com>
Subject: Re: Slowness (search opens every email file?)
Message-ID: <20110713050316.GH25558@mit.edu>
References: <20110711190721.GA5386@compy.jasonwoof.org>
	<CAH-f9WtBHJ8bL6eWoSNrTs=jkrOYYCuWEVVPDUt_iCw0dKcZbw@mail.gmail.com>
	<20110712202459.GB15019@compy.jasonwoof.org>
	<CAH-f9WujE8s3DK1PyDGf3kdWLx2qvPx=dp7WZ-z_v8prqauvug@mail.gmail.com>
	<m3pqlfhrkk.fsf@zsu.kismala.com> <20110713022247.GG25558@mit.edu>
	<m3liw2j2u3.fsf@zsu.kismala.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3liw2j2u3.fsf@zsu.kismala.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

Quoth Istvan Marko on Jul 12 at  8:07 pm:
> Austin Clements <amdragon@MIT.EDU> writes:
> 
> > I'd say this patch looks good other than coding style
> > - Tab indentation
> > - /* */ comments, starting with a capital letter
> > - Space between function name and open paren
> > - Space after comma in argument lists
> > - Spaces around assignment operator
> 
> Thanks, fixed the ones I see:

+    /* Fetch header from the appropriate xapian value field if
+     * available */
+    if (strcmp(header, "from") == 0)
+       value = message->doc.get_value(NOTMUCH_VALUE_FROM);
+    else if (strcmp(header, "subject") == 0)
+       value = message->doc.get_value (NOTMUCH_VALUE_SUBJECT);
+    else if (strcmp(header, "message-id") == 0)
+       value = message->doc.get_value (NOTMUCH_VALUE_MESSAGE_ID);

The strcmp's should have a space before the paren, as should the first
get_value.  (Yeah, it's weird.  Blame glib.)

Also, it occurred to me that these should be strcasecmp's, since
headers are case-insensitive.