To: Aaron Ecay <aaronecay@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [RFC][PATCH v2] emacs: Re-implement advance/rewind functions of
	notmuch-show-mode.
In-Reply-To: <m2wr9ollwc.fsf@gmail.com>
References: <1324553312-10972-1-git-send-email-dme@dme.org>
	<1324556204-15700-1-git-send-email-dme@dme.org>
	<m2wr9ollwc.fsf@gmail.com>
User-Agent: Notmuch/0.10.2+107~ga2d0215 (http://notmuchmail.org)
	Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Thu, 22 Dec 2011 15:27:22 +0000
Message-ID: <cun4nwswrs5.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain

On Thu, 22 Dec 2011 09:29:55 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> Would the problem you had with previous-s-c-prop-change be fixed by the
> patch to the original function I sent in the thread starting at
> id:"m2y5u5cykp.fsf@kcals.intra.maillard.im" ?

I think so, yes. Re-writing the new version I posted to use
`previous-single-char-property-value' in the way that you describe:

   ((let ((visible-bottom (notmuch-show-message-bottom)))
      (while (invisible-p visible-bottom)
	(setq visible-bottom (max (point-min)
				  (1- (previous-single-char-property-change
				       visible-bottom 'invisible)))))
      (> visible-bottom (window-end)))
    ;; The end of this message is not visible - scroll.
    (scroll-up)
    nil)

seems to work in quick testing.

I'd vote to integrate your change if it seems correct to everyone else,
then I'll argue for a re-write separately.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk7zTFsACgkQaezQq/BJZRZ2wwCeI877t4HEkME2lHH04V0qjzxJ
W/8An0uNJsW6qD4VXV5qqS7Xd6svBwo9
=I28a
-----END PGP SIGNATURE-----
--=-=-=--