Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0FCE0431FB6 for ; Mon, 15 Oct 2012 20:12:59 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LXM0nDgIEHcj for ; Mon, 15 Oct 2012 20:12:55 -0700 (PDT) Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 639B2431FAE for ; Mon, 15 Oct 2012 20:12:55 -0700 (PDT) Received: by mail-qc0-f181.google.com with SMTP id x40so5296673qcp.26 for ; Mon, 15 Oct 2012 20:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=TE0+Y5vnaQhISMV3QVY3YWrNJyEOR4nldJh5TfQg7l8=; b=jXMdJs924v1Rh21dqRsPs0jASVh9YlJdXVBEx+NY4IHdz4EBDLunPD/WpaHQP0sFPH 4ilg+AXhu9Q4SBR04T9zu9pSihCjcK8a6Y4RTgri4EgGvUlz2k8McElGgHXk1AM8vWYI SbP2XixmtwiX3UGVGy/eKwJ3nb1pLwEHZnrY1ZYSWMSc4gkmJxdHDp+HqTB36KE6pk/m aAd7cH2Ti+yBs66/KUlfNZ4cuUciTKTpRuPE7wVUzK9Tiyno20yyhJsYD7/q7qhf9MwQ s/4n0bJ550Nv4KAZg7BvZDavvSLHUXe7Yf0MGbixWvjc6lZfUm31MkuCfsDQilo+BPTZ ZvMQ== Received: by 10.229.136.81 with SMTP id q17mr6478714qct.115.1350357174872; Mon, 15 Oct 2012 20:12:54 -0700 (PDT) Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80]) by mx.google.com with ESMTPS id ch3sm17337002qab.9.2012.10.15.20.12.53 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 15 Oct 2012 20:12:54 -0700 (PDT) From: Ethan Glasser-Camp To: Mark Walters , Pieter Praet , David Bremner , Dmitry Kurochkin Subject: Re: [PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}' In-Reply-To: <87sjh2wx8z.fsf@qmul.ac.uk> References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca> <1330122640-18895-1-git-send-email-pieter@praet.org> <1330122640-18895-6-git-send-email-pieter@praet.org> <87sjh2wx8z.fsf@qmul.ac.uk> User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 15 Oct 2012 23:12:51 -0400 Message-ID: <87k3ur85zg.fsf@betacantrips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2012 03:12:59 -0000 Mark Walters writes: > I like the use of separator rather than hard-wiring " or ". My personal > preference would be to make that change but keep the two functions > separate (my "C"ness makes me like functions that have clear return > types!) But I am happy with the change too. I agree with this comment. Especially in dynamic languages, it's a good idea for each function to have only one return type. Also, it seems that the commit message has a TAB character in it (",-search"). Ethan