DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	b=X3RVP679XpZIaLb7DX+6ap6U+vNrcRQ6ZolEfsLlTGFsGRXy9XK+iIpO7z5NnPysot
	9MLJbBN02AGALOn6TLPdpoDfNcFrSxCCwYcYro7FGLriEPabTUQZv0WnpPawyp3LdiIJ
	G8dDk8WESenpfxAk6pRGJpmqlnDOM0oFWvh84=
MIME-Version: 1.0
Sender: amdragon@gmail.com
In-Reply-To: <871uznrbh5.fsf@gmail.com>
References: <1306090675-26982-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1306164587-20326-1-git-send-email-dmitry.kurochkin@gmail.com>
	<87oc2rlujb.fsf@yoom.home.cworth.org> <8762ozrfrr.fsf@gmail.com>
	<87oc2rvjvj.fsf@yoom.home.cworth.org> <871uznrbh5.fsf@gmail.com>
Date: Tue, 24 May 2011 18:43:41 -0400
Message-ID: <BANLkTi=_PszwPDRbRxVpVhkT=YRAi5dGDQ@mail.gmail.com>
Subject: Re: [PATCH] Save and restore point explicitly in
	`notmuch-wash-toggle-invisible-action'.
From: Austin Clements <amdragon@mit.edu>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: notmuch@notmuchmail.org
Precedence: list

On Tue, May 24, 2011 at 6:16 PM, Dmitry Kurochkin
<dmitry.kurochkin@gmail.com> wrote:
> When a user clicks the button, the cursor is somewhere inside the old
> label. =A0If we save the point as a marker, after step 3 it would end up
> at the position where the old label was. =A0If the new label is inserted
> before the old one, that means after the new label. =A0So the cursor jump=
s
> from inside the button to the position after the button. =A0Since the new
> button is placed at the same position where the old one was, restoring
> the point to the same offset it was at the beginning works as we need.

Saving point this way is a bit dangerous, though.  For example, if
you're near the end of the buffer and shorten the label, attempting to
restore the point could result in an error (or, a more benign example:
the cursor could wind up outside the label so pressing RET repeatedly
won't toggle it).

Unfortunately, I don't know of a clean solution to this, but I think I
would rather the cursor move, but stay within the label (probably
moving to the beginning), than have problems like the above.