MIME-Version: 1.0
Sender: amdragon@gmail.com
In-Reply-To: <1316108471.2201.24.camel@delen>
References: <1315110898.32058.13.camel@delen> <87vct7t7m4.fsf@SSpaeth.de>
	<1315373219.32058.157.camel@delen> <8739g7gnb4.fsf@SSpaeth.de>
	<1316108471.2201.24.camel@delen>
Date: Thu, 15 Sep 2011 14:12:22 -0400
Message-ID:
 <CAH-f9Wu-9pvX=E6UatXdEMdmSQFz2t_-OM4DWFE0-Y+NXKBk4g@mail.gmail.com>
Subject: Re: Python Unicode Was: Not much database creation error
From: Austin Clements <amdragon@mit.edu>
To: Martin Owens <doctormo@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Notmuch developer list <notmuch@notmuchmail.org>,
	Paul Tagliamonte <tag@pault.ag>
Precedence: list

This seems like a symptom of a much bigger problem.  Shouldn't the
bindings be checking or coercing the type of *every* argument that
gets passed from the caller through to a ctypes-wrapped libnotmuch
function?  Otherwise, a simple type error in a caller, like passing a
number instead of a string to one of the Python methods, would likely
result in a segfault.

On Thu, Sep 15, 2011 at 1:41 PM, Martin Owens <doctormo@gmail.com> wrote:
> Hello Sebastian,
>
> I've attached a diff for some proposed changes to help make dealing with
> unicode and strings in the bindings more regular. I noticed some of the
> methods were protected and others were not.
>
> Let me know.
>
> Best Regards, Martin Owens
>
> On Thu, 2011-09-08 at 15:45 +0200, Sebastian Spaeth wrote:
>> I have to admit, I am not deep into the libnotmuch/xapian internals,
>> so
>> I might be the wrong person to ask (I just do some python bindings to
>> whatever libnotmuch provides).