Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5E391431FD0 for ; Fri, 21 Oct 2011 13:51:02 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.79 X-Spam-Level: X-Spam-Status: No, score=-0.79 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UTPnh0VFBKJV for ; Fri, 21 Oct 2011 13:51:01 -0700 (PDT) Received: from mail-ey0-f181.google.com (mail-ey0-f181.google.com [209.85.215.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id D0EAB431FB6 for ; Fri, 21 Oct 2011 13:51:00 -0700 (PDT) Received: by eyx24 with SMTP id 24so5401609eyx.26 for ; Fri, 21 Oct 2011 13:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schoepe.org; s=google; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=ZwbKE+/fTUypzyDML1wnoUoQAdjtJhxJkEkGBUdBhyk=; b=Eq9FoiTaV4zgSw9rMVd5O02/uHhhiTDbScdsmBOfbjaLtlOVY0+EnqhDfhvK2D08EG 5Q0Hks9BFDYTmyUV9whNDAvyhWGvCxhhi1NvffJIbOHv9K1AUnQ3X7JCOp+YpnY2S09T mZvH+028ZyIVZNNtgzYrBjzJ7B+e0OlWdBMtk= Received: by 10.223.76.24 with SMTP id a24mr17416746fak.31.1319230258162; Fri, 21 Oct 2011 13:50:58 -0700 (PDT) Received: from localhost (dslb-188-107-195-138.pools.arcor-ip.net. [188.107.195.138]) by mx.google.com with ESMTPS id q11sm24174765fad.20.2011.10.21.13.50.55 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 21 Oct 2011 13:50:56 -0700 (PDT) From: Daniel Schoepe To: James Vasile , notmuch@notmuchmail.org Subject: Re: [notmuch] [PATCH] Calls to notmuch get queued and executed asynchronously. In-Reply-To: <87vddnlxos.wl%james@hackervisions.org> References: <87vddnlxos.wl%james@hackervisions.org> User-Agent: Notmuch/0.9-19-ga25c9a0 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 21 Oct 2011 22:50:48 +0200 Message-ID: <87wrbykr13.fsf@gilead.invalid> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2011 20:51:02 -0000 --=-=-= On Tue, 23 Feb 2010 11:32:51 -0500, James Vasile wrote: > Added notmuch-enqueue-asynch to replace calls to > notmuch-call-notmuch-process. Calls to notmuch are then queued and > executed asynchronously. If the db is busy and we get an error saying > it was locked, keep trying until the db is no longer busy. Errors go > in a buffer as per usual. I discovered this patch a while ago and it almost applies cleanly (the conflicts are easy to fix though) and it has made the emacs UI for notmuch _much_ more responsive and enjoyable for me. As discussed on IRC, issues such as where to handle retries in case the database is locked should probably be handled in the notmuch binary instead of each UI. I am however unaware of any patches to accomplish that and with the pace of development / patch reviews the way it is at the moment, this patch is a really helpful stop-gap (performing calls to notmuch asynchronously is useful independently of where concurrency issues are handled though) for me. If someone else agrees, I can fix the conflicts for this patch and send the revised version to the list. Cheers, Daniel --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJOodsoAAoJEIaTAtce+Z+JfcUQAKRAClcxOAvAU3c2tEGNXNwf DRvbttxYt+YtoGaBNwoyNRfHjg0elwGSVGd860ApbL4LC0coYADGOd0o41uXHLgJ Zx0S/7MYwVZ+bh+0mlZ67wIGvvF9rqEkUmjoOCrAGIneBuSstLFTEsOVUL9+4rLX qPGhhs6uTr0WWUHoSJwTlKeB8UruUORdTySyiMnjnRgUmkLrPEa1CIDatFAl/rSv +CQZd1nZv7brZKrgPlJotb5S8bkHsceFmg699XwnvaEGegyuDvl8Etx6wjypVOZg wTPysTZqmAn66P1Stpfdk8A0W+zXxRh2m7VcGi6rRtWKjaxEvtuxDCrxxR6HQFal 6mkda6hRVCIGxf7CFeL5Qnjh9HFjO+2oMQcYZfsLikmZ9ymN41CB+W2Yd36LB8LY 1b2wxKTMjmT3iXfmQOxfuJkeXr9zvGk/UuxEhxt+P4nePLU3oDGYhpHeoaY5Ih0G 6yFxzgh91lE/VEvJga4Jt/O6Po0j3eJ9jgvsmk4oyZT8rfW7HlYv5cBQIcfI2urq jfIypf8H5BCp3zEYdiC43KELmd7tGlaUz36Zo6inIBukA5DiOJLbcMTB48taSVQ0 6dv9ntdIjNBrP1wmoEFCyoQVCE3mkGoN2ReBeh5ElfkebWO/nFQ04eblCTTQOtrf MEBp78DNobSEFos4fkfl =1ogW -----END PGP SIGNATURE----- --=-=-=--