From: Jani Nikula <jani@nikula.org>
To: David Bremner <david@tethera.net>, Pieter Praet <pieter@praet.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] add `tag:' prefix to `--output=tags' results
In-Reply-To: <87k475mktx.fsf@rocinante.cs.unb.ca>
References: <877hbiep5g.fsf@SSpaeth.de>
	<1309422029-22924-1-git-send-email-pieter@praet.org>
	<87k475mktx.fsf@rocinante.cs.unb.ca>
User-Agent: Notmuch/0.9+52~g41ba966 (http://notmuchmail.org) Emacs/23.3.1
	(i686-pc-linux-gnu)
Date: Sun, 13 Nov 2011 16:14:35 +0200
Message-ID: <87k474cdo4.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Sat, 12 Nov 2011 10:17:30 -0500, David Bremner <david@tethera.net> wrote:
> On Thu, 30 Jun 2011 10:20:29 +0200, Pieter Praet <pieter@praet.org> wrote:
> > Alter `do_search_tags()' to prepend each result with `tag:',
> > and update affected test.
> > 
> > This makes its output consistent with `do_search_threads()' and
> > `do_search_messages()'.
> 
> What do people think about this change? Personally I will have change
> some scripts to not add "tag:", but it isn't that big of a deal.

I'm curious why this change is needed in the first place. What is gained
from this in addition to consistency? It seems I don't have enough list
history to find the referenced discussion.

The command line interface is an API, and this change causes regressions
in all scripts and programs using it, including the emacs ui. (And that
should probably be fixed with something other than "...a quick'n'dirty
patch, thus probably not fit for consumption.")

BR,
Jani.