From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] contrib: pick: add thread based utility functions
In-Reply-To: <878v30kh8p.fsf@qmul.ac.uk>
References: <1354970914-18342-1-git-send-email-markwalters1009@gmail.com>
	<1354970914-18342-2-git-send-email-markwalters1009@gmail.com>
	<87fvxswgff.fsf@zancas.localnet> <878v30kh8p.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.15.2+69~g360c3c8 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 01 Jun 2013 09:36:51 -0300
Message-ID: <87ppw6ypln.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

Mark Walters <markwalters1009@gmail.com> writes:
>
> David Bremner <david@tethera.net> writes:
>
>
>> More importantly, in emacs 24.3 I get an infinite loop when trying to
>> evaluate the update notmuch-pick.el. 
>
> I think this is just stupidity on my part: it should be a defun rather
> than a defmacro. Would you be able to test that (or I can send a new
> version if you prefer)?
>

Yes, changing that defmacro to a defun fixes the loop.

I load pick as follows

    (add-to-list 'load-path
                 (expand-file-name "~/software/upstream/notmuch/contrib/notmuch-pick"))
    (require 'notmuch-pick nil t)


I'll need another version in any case, since it doesn't apply to master
anymore, but hold off for a review of 2/2.

d