Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 199D2431FB6
	for <notmuch@notmuchmail.org>; Sun, 21 Sep 2014 08:25:28 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 0Uv2nD50o8Lu for <notmuch@notmuchmail.org>;
	Sun, 21 Sep 2014 08:25:20 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 8DD97431FAE
	for <notmuch@notmuchmail.org>; Sun, 21 Sep 2014 08:25:20 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id E3A2E100033;
	Sun, 21 Sep 2014 18:24:53 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test/emacs: globally force the html renderer to html2text
In-Reply-To: <1411191695-21933-1-git-send-email-david@tethera.net>
References: <1411191695-21933-1-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.18.1+97~g6c845ef (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sun, 21 Sep 2014 18:24:53 +0300
Message-ID: <m2bnq9c7y2.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Sep 2014 15:25:28 -0000

On Sat, Sep 20 2014, David Bremner <david@tethera.net> wrote:

> Previously we did this for a single test, but some other proposed
> tests ( id:1398105468-14317-3-git-send-email-amdragon@mit.edu ) show
> similar breakage when switching renderers.

LGTM.

Tomi

PS: in that file we don't seem to have unified style with comment
capitalization, trailing periods and newlines between comment and code.

> ---
>  test/T310-emacs.sh | 2 +-
>  test/test-lib.el   | 5 +++++
>  2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh
> index ac966e5..c302402 100755
> --- a/test/T310-emacs.sh
> +++ b/test/T310-emacs.sh
> @@ -483,7 +483,7 @@ test_expect_equal_file OUTPUT EXPECTED
>  test_begin_subtest "Reply within emacs to an html-only message"
>  add_message '[content-type]="text/html"' \
>  	    '[body]="Hi,<br />This is an <b>HTML</b> test message.<br /><br />OK?"'
> -test_emacs "(let ((message-hidden-headers '()) (mm-text-html-renderer 'html2text))
> +test_emacs "(let ((message-hidden-headers '()))
>  	    (notmuch-show \"id:${gen_msg_id}\")
>  	    (notmuch-show-reply)
>  	    (test-output))"
> diff --git a/test/test-lib.el b/test/test-lib.el
> index 36afe63..bbc03cb 100644
> --- a/test/test-lib.el
> +++ b/test/test-lib.el
> @@ -181,3 +181,8 @@ nothing."
>  ;; suite
>  (setq notmuch-tag-deleted-formats
>        '((".*" nil)))
> +
> +;; force a common html renderer, to avoid test variations between
> +;; environments
> +
> +(setq mm-text-html-renderer 'html2text)
> -- 
> 2.1.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch