Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 144CF4196F2 for ; Thu, 4 Nov 2010 07:13:06 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w-ok2qpJAt6j for ; Thu, 4 Nov 2010 07:12:55 -0700 (PDT) Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) by olra.theworths.org (Postfix) with ESMTP id A9E0F4196F0 for ; Thu, 4 Nov 2010 07:12:55 -0700 (PDT) Received: from localhost (unknown [192.168.200.4]) by max.feld.cvut.cz (Postfix) with ESMTP id 06E1819F3377; Thu, 4 Nov 2010 15:12:55 +0100 (CET) X-Virus-Scanned: IMAP AMAVIS Received: from max.feld.cvut.cz ([192.168.200.1]) by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, port 10044) with ESMTP id dO5IF1i84VK4; Thu, 4 Nov 2010 15:12:53 +0100 (CET) Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) by max.feld.cvut.cz (Postfix) with ESMTP id BA5A219F32FB; Thu, 4 Nov 2010 15:12:53 +0100 (CET) Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30]) (Authenticated sender: sojkam1) by imap.feld.cvut.cz (Postfix) with ESMTPSA id AB018FA003; Thu, 4 Nov 2010 15:12:53 +0100 (CET) Received: from wsh by steelpick.2x.cz with local (Exim 4.72) (envelope-from ) id 1PE0Yf-0003FL-H3; Thu, 04 Nov 2010 15:12:53 +0100 From: Michal Sojka To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: Do not color non-matching authors by tag In-Reply-To: <878w1942i6.fsf@ut.hh.sledj.net> References: <1287726122-5643-1-git-send-email-sojkam1@fel.cvut.cz> <878w1942i6.fsf@ut.hh.sledj.net> User-Agent: Notmuch/0.4-29-g9b64b0f (http://notmuchmail.org) Emacs/23.2.1 (x86_64-pc-linux-gnu) Date: Thu, 04 Nov 2010 15:12:53 +0100 Message-ID: <87vd4djhy2.fsf@steelpick.2x.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2010 14:13:06 -0000 Hi David, On Thu, 04 Nov 2010, David Edmondson wrote: > On Fri, 22 Oct 2010 07:42:02 +0200, Michal Sojka wrote: > > Customizing notmuch-search-line-faces to color lines in search result > > according to tags has the effect that the color overrides other faces > > set for the line. This is usually what the user wants with the > > exception that it also colors non-matching authors and it is then not > > possible to visually distinguish between matching and non-matching > > authors. > > > > This patch changes the way how are the faces specified in > > notmuch-search-line-faces applied to the search results. In > > particular, instead of adding an overlay for the whole line, the > > existing faces of the line are replaced with what is given in > > notmuch-search-line-faces. The only exception is that > > notmuch-search-non-matching-authors face is never replaced. > > > Michal, was this addressed by the patch that Carl recently merged? > (Commit f99ad42da03afd638bfdfdea92d1cbdd3b510b8f in my copy of the > repository.) Unfortunately not. In your patch, the overlay changes the color/face of the whole line while my patch change the color/face of all parts of the line except for non-matching authors. With my patch non-matched autors were always grayed even if the rest of line was colorized. My patch no loger applies to the current HEAD. I plan to update it some time later, but if you want to implement this, it would be great :-) -Michal