Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 659E2431FB6 for ; Sun, 27 Feb 2011 00:15:45 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tQiWrq+J2DXv for ; Sun, 27 Feb 2011 00:15:44 -0800 (PST) Received: from mail-qw0-f53.google.com (mail-qw0-f53.google.com [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 5C4D3431FB5 for ; Sun, 27 Feb 2011 00:15:44 -0800 (PST) Received: by qwc9 with SMTP id 9so2374802qwc.26 for ; Sun, 27 Feb 2011 00:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=z2Xjgbcbjeydld4aHDovPZsKkspPY5CVO49kNRnv0JE=; b=UwpSjWmc29p9evWpz9jgB3H360VMJFh1BrFvDd6T7DLpW5OxmyPJ1d/EHCrVgo3Af8 7gA3ofAqSfRC7EsBste9f5+dMHnqld8V0w32bpnepCEuQMVNj2z/6GkjbX3YhecL4GX7 IcVLXVVRGjxnb1uMVFhx+YVhWImr9elcRGG2s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=cEkz7sfyG3Id5je3hiDur9QuTJ0KyXAk9Mmp51Gb5j4yyyhdC8UTaP7XRjiaQKYICe yHgQGwCvMoRdOV2fcfF3QRlvRunZFx9S06WYbLJj205TX6Hu88g1LMxeDPV43nMGc7F9 uCeeysgpiPwH7zHxAZYwa2hMuoOU5qygyuUHc= MIME-Version: 1.0 Received: by 10.224.45.74 with SMTP id d10mr3514125qaf.304.1298794541563; Sun, 27 Feb 2011 00:15:41 -0800 (PST) Sender: amdragon@gmail.com Received: by 10.229.105.68 with HTTP; Sun, 27 Feb 2011 00:15:41 -0800 (PST) In-Reply-To: References: Date: Sun, 27 Feb 2011 03:15:41 -0500 X-Google-Sender-Auth: JBbqdFYBoNHM9x8XsabC5FMINxk Message-ID: Subject: Re: [PATCH] Return error status from notmuch_message_tags_to_maildir_flags(). From: Austin Clements To: Rob Browning Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Feb 2011 08:15:45 -0000 Looks good to me, but it appears that both callers of notmuch_message_tags_to_maildir_flags ignore the return value. Both callers synchronize maildir flags immediately after thawing the tag changes on a message. Perhaps they should instead synchronize *before* thawing and abort if the sync fails? On Tue, Feb 15, 2011 at 1:07 AM, Rob Browning wrote: > Signed-off-by: Rob Browning > --- > =A0lib/message.cc | =A0 =A02 +- > =A01 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/message.cc b/lib/message.cc > index 0590f76..979fad5 100644 > --- a/lib/message.cc > +++ b/lib/message.cc > @@ -1252,7 +1252,7 @@ notmuch_message_tags_to_maildir_flags (notmuch_mess= age_t *message) > =A0 =A0 talloc_free (to_set); > =A0 =A0 talloc_free (to_clear); > > - =A0 =A0return NOTMUCH_STATUS_SUCCESS; > + =A0 =A0return status; > =A0} > > =A0notmuch_status_t > -- > 1.7.2.3 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch >