From: Daniel Schoepe <daniel.schoepe@googlemail.com>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 1/2] emacs: User-defined sections in notmuch-hello
In-Reply-To: <871uy25d3y.fsf@steelpick.2x.cz>
References: <1309379221-5617-1-git-send-email-daniel.schoepe@googlemail.com>
	<1309883030-28899-1-git-send-email-daniel.schoepe@googlemail.com>
	<1309883030-28899-2-git-send-email-daniel.schoepe@googlemail.com>
	<87fwmjabii.fsf@steelpick.2x.cz>
	<87oc17r38a.fsf@tredergarh.home.box>
	<871uy25d3y.fsf@steelpick.2x.cz>
User-Agent: Notmuch/0.5-319-g20a5437 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Thu, 07 Jul 2011 20:25:37 +0200
Message-ID: <87wrfuc5i6.fsf@gilead.invalid>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Thu, 07 Jul 2011 17:23:13 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrot=
e:
> This wouldn't work for me. My all-tags section covers almost entire
> screen and finding non-zero entries there is not very convenient. I find
> much more useful to have a section saying: "Hey, you have unread
> messages only for these three tags". Moreover, it wouldn't help me to see
> non-zero number of unread messages and when I click the button I would
> see all the messages, not only the unread ones. It simply seems very
> confusing to me.

I agree with you, personally, but I don't think this particular bit
(:hide-empty-searches) increases code complexity that much (and all of
it is localized to the functions generating the sections, which possibly
should be moved to a separate file). I also find it plausible that a
user might want behavior like this (as, e.g. an overview, if he doesn't
want an all tags section, but still see what tags he has set).

Hence I don't see why we should not provide this option.

> > If we decide to keep this functionality, it should be inverted though,
> > i.e. one has to explicitly specify :show-empty-searches to get them.
>=20
> >=20
> > About the counts: I introduced this because Austin Clements says he
> > finds it useful in his comment here:
> >=20
> > id:"BANLkTi=3D729DWai4q57iBSfz1wDhBXsmndQ@mail.gmail.com"
>=20
> I agree that it is useful to see unread counts, but it is not useful to
> see all messages when I click the button.

As I said, this is not my preference either, but personal taste is not
necessarily the best argument for _not including_ something, especially
for the UI of a mail client. And in this case there even is someone
saying that behavior would be useful to him.

> > A user might still want to have the section collapsed when starting the
> > notmuch UI and only have it shown when he needs it. (I use that for a
> > section that displays unread counts for each tag).
>=20
> You are right. I use emacs --daemon so I actually initialize notmuch UI
> only when emacs crashes or when I run out of battery power ;-)

Yes, me too, but I like seeing only sections that I care about every
time I open notmuch while still having more information available in a
convenient way. But I'm not too attached to this feature, so if the
consensus is that that bit should be removed, I'll bow to public opinion. :)

> If I understand this variable correctly, it stores the label (text) of
> the button you have your point at. This allows you to stay at the same
> button after reloading of notmuch-hello even if the layout changes,
> right? Then having the same named button in multiple sections results in
> moving the first (or last) occurrence of this button when notmuch-hello
> is reloaded.

Ah, I misunderstood what you were referring to earlier. That was already
case before my patch though, except that now it's more likely to have
buttons with the same name. Anyway, I think this is just a minor issue
and can be addressed in a different patch.

In any event, this definitely needs better documentation.

Thanks for all your input on this!

Cheers,
Daniel

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJOFfoiAAoJEIaTAtce+Z+JdO0QALZH8JFgm6aUZniQK0INCWAk
71rME1nUG7YFoJZbVRg7ugQykoSXGEWct37fIIz+K0tghL1qegG+EJwKivpQqPa2
cHsTjxBUuamyEVrvf96pzHMk8UVUmhYOx3XMtzUt/gJmGxHatph+F7JQFx4whLvy
cZYuYeAIg+dZJx8ylkMrgTtwgOjNLiwwGds4RWwCt2iwVccP6TwrWRiXkOiqcFD7
dRQd474W2noVxE5Mn8TOh6LpCmtJhrysooKvSU4yat2mYZUN1Nm7t9CvCMEgEU9c
HYJOR+zoyiVQKM9hhjO5Ts4HboJzsFbyJA9jXAJ8J09m2sphg0KCd1wCa2JaG94/
SwGdPFjW/4usEWj+szRcCc4XFPmc3pyo/eSJ8BTjmfRtWoO56vF+w3Y3dkYeG09s
03r7oG9tixmut8wNH5QYimME8qxcQCrOMUfjd2vPQ5Qgx892dwpmy3ZP3Wuv9SHA
cJdxzUB7GclMYggXHjMDH41d7oSZd9MMOQCWB7U3kTCoTjy4HJ3iG49KH1mblld0
desbjIrZ3qd96Mb9IVRk4RrFlEIuS1QW9P+zJqCoJAXvdOtnSXddF2sHDSgqqucC
lopsc/cxnU21JYbzrdNuIjyOF5Z5qXg9bW0YjzJ0HZLDvEV0Ac7Igi+0NtMsV3uT
/vDpiofVKBsU/fP1UyJH
=lBAa
-----END PGP SIGNATURE-----
--=-=-=--