From: Daniel Schoepe <daniel@schoepe.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/5] cli/count: add --lastmod
In-Reply-To: <1439570878-15165-4-git-send-email-david@tethera.net>
References: <1439570878-15165-1-git-send-email-david@tethera.net>
 <1439570878-15165-4-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.20.2+64~g9f61b4c (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-unknown-linux-gnu)
Date: Sat, 15 Aug 2015 09:21:49 +0200
Message-ID: <878u9dyq2a.fsf@schoepe.localhost>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Fri, 14 Aug 2015 18:47 +0200, David Bremner wrote:
> +    ``--lastmod``
> +	Append lastmod (counter for number of database updates) and UUID
> +	to the output. lastmod values are only comparable between databases
> +	with the same UUID.

Sorry to keep harping on this, but I'm not entirely happy with the way
we handle notmuch-compact here (and in the other commit that mentions
compacting explicitly). Given that lastmod values (and pretty much
everything else) aren't affected by compacting, would it perhaps make
sense to copy the previous UUID to the newly compacted database?

Given that a compacted database is "indistinguishable" from the previous
non-compacted database, we may want to signal that it's still the "same
database". Is there a case where compacting actually makes a difference
to anything making use of lastmod values?

Best regards,
Daniel