Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5AD2B40DF1F for ; Sat, 20 Nov 2010 15:54:36 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f25tB3hwLR-b for ; Sat, 20 Nov 2010 15:54:24 -0800 (PST) Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) by olra.theworths.org (Postfix) with ESMTP id 423B940DEEB for ; Sat, 20 Nov 2010 15:54:24 -0800 (PST) Received: from localhost (unknown [192.168.200.4]) by max.feld.cvut.cz (Postfix) with ESMTP id 8C17519F3352; Sun, 21 Nov 2010 00:54:23 +0100 (CET) X-Virus-Scanned: IMAP AMAVIS Received: from max.feld.cvut.cz ([192.168.200.1]) by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, port 10044) with ESMTP id ZQRKrOD+p7ed; Sun, 21 Nov 2010 00:54:22 +0100 (CET) Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) by max.feld.cvut.cz (Postfix) with ESMTP id 0BB2719F334C; Sun, 21 Nov 2010 00:54:22 +0100 (CET) Received: from wsheee.2x.cz (unknown [213.29.198.144]) (Authenticated sender: sojkam1) by imap.feld.cvut.cz (Postfix) with ESMTPSA id A9CD6FA003; Sun, 21 Nov 2010 00:54:21 +0100 (CET) Received: from wsh by wsheee.2x.cz with local (Exim 4.72) (envelope-from ) id 1PJxG9-0000cy-1d; Sun, 21 Nov 2010 00:54:21 +0100 From: Michal Sojka To: meskio@sindominio.net, notmuch@notmuchmail.org Subject: [PATCH] Additional maildir-sync test In-Reply-To: <87pqtzk254.fsf@wsheee.2x.cz> References: <20101118153744.GE3049@blackspot> <1290181264-5900-1-git-send-email-meskio@sindominio.net> <87pqtzk254.fsf@wsheee.2x.cz> User-Agent: Notmuch/0.5-11-g48b5e00 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Sun, 21 Nov 2010 00:54:20 +0100 Message-ID: <87mxp3k0ur.fsf@wsheee.2x.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Nov 2010 23:54:36 -0000 On Sat, 20 Nov 2010, Michal Sojka wrote: > your patch fixes the problem, but it also breaks one of the tests in > test suite. I created the test for your patch ... and here is another test which was in my original synchronization patches, but Carl decided to remove it. It checks that tagging message by an unrelated tag does not move the message from new to cur. This test currently fails. In id:"20100323143714.GE28596@blackspot" Ruben wrote that for some mail readers there is a difference between mails in new and mails without "S" flag in cur. Ruben, is the current behavior problematic for you? Carl, did you have some reason to remove this functionality? -Michal diff --git a/test/maildir-sync b/test/maildir-sync index 4419a7e..8da12dd 100755 --- a/test/maildir-sync +++ b/test/maildir-sync @@ -185,4 +185,10 @@ add_message [subject]='"Message in new without maildir info"' [date]='"Sat, 01 J output=$(notmuch search subject:"Message in new without maildir info" | notmuch_search_sanitize) test_expect_equal "$output" "thread:XXX 2000-01-01 [1/1] Notmuch Test Suite; Message in new without maildir info (inbox unread)" +test_begin_subtest "Non-maildir-syncable tag should not move the message from new" +add_message [subject]='"Message to stay in new after tagging"' [date]='"Sat, 01 Jan 2000 12:00:00 -0000"' [filename]='message-to-stay-in-new-after-tagging' [dir]=new +notmuch tag +non-maildir-syncable subject:"Message to stay in new after tagging" +output=$(cd "$MAIL_DIR"; find -name 'message-to-stay-in-new-after-tagging*') +test_expect_equal "$output" "./new/message-to-stay-in-new-after-tagging" + test_done