Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2AFA7431FBF for ; Mon, 23 Nov 2009 07:41:25 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dw8FEnv8tqmq for ; Mon, 23 Nov 2009 07:41:24 -0800 (PST) Received: from bach.exherbo.org (bach.exherbo.org [78.47.197.147]) by olra.theworths.org (Postfix) with ESMTP id 7DAB3431FAE for ; Mon, 23 Nov 2009 07:41:24 -0800 (PST) Received: from [83.101.72.69] (helo=localhost) by bach.exherbo.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1NCb2Z-0006J3-P1 for notmuch@notmuchmail.org; Mon, 23 Nov 2009 15:41:23 +0000 Content-Type: text/plain; charset=utf8 From: Ingmar Vanhassel To: notmuch In-reply-to: <46263c600911230731i529f2db5rec11bed02f84ef13@mail.gmail.com> References: <46263c600911230731i529f2db5rec11bed02f84ef13@mail.gmail.com> Date: Mon, 23 Nov 2009 16:41:23 +0100 Message-Id: <1258990831-sup-2789@cannonball> User-Agent: Sup/git Content-Transfer-Encoding: 8bit Subject: Re: [notmuch] [patch] Trivial fix for non-root install X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2009 15:41:25 -0000 Excerpts from Brett Viren's message of Mon Nov 23 16:31:47 +0100 2009: > Installing as a normal user fails because the bash completion config > files try to install into /etc. This trivial patch fixes this. NAK Your patch breaks the more common case of installing as root user. It now installs into /usr/etc where bash completions most likely won't be found. > diff --git a/Makefile.config b/Makefile.config > index ddc7436..c04d57a 100644 > --- a/Makefile.config > +++ b/Makefile.config > @@ -1,3 +1,2 @@ > -prefix = /usr/local > -bash_completion_dir = /etc/bash_completion.d > +bash_completion_dir = $(prefix)/etc/bash_completion.d > CFLAGS += -DHAVE_VALGRIND > > > -Brett. -- Exherbo KDE, X.org maintainer