Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 48841431FB6 for ; Sat, 18 Feb 2012 14:11:04 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DZYZn4pGlUGm for ; Sat, 18 Feb 2012 14:11:02 -0800 (PST) Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) by olra.theworths.org (Postfix) with ESMTP id 7660B431FAE for ; Sat, 18 Feb 2012 14:11:02 -0800 (PST) Received: from localhost (unknown [192.168.200.4]) by max.feld.cvut.cz (Postfix) with ESMTP id 095D019F3418; Sat, 18 Feb 2012 23:11:01 +0100 (CET) X-Virus-Scanned: IMAP AMAVIS Received: from max.feld.cvut.cz ([192.168.200.1]) by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, port 10044) with ESMTP id f3EhnBgcKBNx; Sat, 18 Feb 2012 23:10:59 +0100 (CET) Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) by max.feld.cvut.cz (Postfix) with ESMTP id 518DA19F340C; Sat, 18 Feb 2012 23:10:59 +0100 (CET) Received: from steelpick.2x.cz (unknown [213.29.198.144]) (Authenticated sender: sojkam1) by imap.feld.cvut.cz (Postfix) with ESMTPSA id 82C67660968; Sat, 18 Feb 2012 23:10:55 +0100 (CET) Received: from wsh by steelpick.2x.cz with local (Exim 4.77) (envelope-from ) id 1RysUY-0001Wn-TG; Sat, 18 Feb 2012 23:10:54 +0100 From: Michal Sojka To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH v10 0/2] emacs: User-defined sections in notmuch-hello In-Reply-To: <1329490088-8323-1-git-send-email-dmitry.kurochkin@gmail.com> References: <1310079227-19120-1-git-send-email-daniel.schoepe@googlemail.com> <1329490088-8323-1-git-send-email-dmitry.kurochkin@gmail.com> User-Agent: Notmuch/0.11.1+210~g5c2fc0a (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 18 Feb 2012 23:10:54 +0100 Message-ID: <874nunokr5.fsf@steelpick.2x.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Feb 2012 22:11:04 -0000 On Fri, 17 Feb 2012, Dmitry Kurochkin wrote: > Found a small bug... > > Changes: > > v10: > > * explicitly return nil from `notmuch-hello-insert-recent-searches', > otherwise `indent-rigidly' returns a marker pointing to non-existing > buffer and breaks final-target-pos handling in `notmuch-hello' > > v9: > > * correctly merge bc267b70b01c79f6bdda52641e9cd7574a151eff > > * fix :hide-if-empty description: > > s/and not hidden by show-if-empty/and not shown by show-empty-searches/ > > * fix typo in `notmuch-hello-target' docstring: s/globaly/global/ > > * add docstring for notmuch-hello-first-run > > * fix indentation in `notmuch-hello-insert-saved-searches' > > * fix indentation in `notmuch-hello-insert-searches' docstring > > * fix target position calculation in `notmuch-hello-insert-saved-searches' > > * s/User defined/User-defined/ in tests > > * move tests to a new emacs-hello file Hi, I'd also like to point out to my optimization originally sent in id:"87fwixasq4.fsf@steelpick.2x.cz". I tried it with v10 and it seems that the bug I reported in id:"87aa7lle4t.fsf@steelpick.2x.cz" is no longer there. It looks like that one of Dmitry's "target position calculation" fixes helped here as well. I'm sending the patch again as a reply to this mail, because in the original posting a part of subject was missing. -Michal