Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D10AC431E64 for ; Sat, 10 Jan 2015 01:18:27 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 2.438 X-Spam-Level: ** X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r8VFieAw9cmv for ; Sat, 10 Jan 2015 01:18:24 -0800 (PST) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id A6F34431E62 for ; Sat, 10 Jan 2015 01:18:24 -0800 (PST) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1Y9sBc-0002VR-1I; Sat, 10 Jan 2015 05:18:24 -0400 Received: (nullmailer pid 8029 invoked by uid 1000); Sat, 10 Jan 2015 09:18:18 -0000 From: David Bremner To: Jesse Rosenthal , notmuch@notmuchmail.org Subject: Re: [v2 1/3] thread.cc: Avoid empty thread names if possible. In-Reply-To: <1414615905-22554-2-git-send-email-jrosenthal@jhu.edu> References: <1414615905-22554-1-git-send-email-jrosenthal@jhu.edu> <1414615905-22554-2-git-send-email-jrosenthal@jhu.edu> User-Agent: Notmuch/0.19+10~g215de26 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Sat, 10 Jan 2015 10:18:18 +0100 Message-ID: <87k30vj8o5.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jan 2015 09:18:28 -0000 Jesse Rosenthal writes: > > +#define EMPTY_STRING(s) ((s)[0] == '\0') > + Extra whitespace at end of line. If that's the only issue I can rebase it away, but maybe you want to enable the standard pre-commit hook? > struct visible _notmuch_thread { > notmuch_database_t *notmuch; > char *thread_id; > @@ -330,11 +332,13 @@ _thread_set_subject_from_message (notmuch_thread_t *thread, > } else { > cleaned_subject = talloc_strdup (thread, subject); > } > + Same here. >