Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 27460431FAF for ; Fri, 30 Nov 2012 20:30:05 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yhd49qfCx-zl for ; Fri, 30 Nov 2012 20:30:04 -0800 (PST) Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU [18.9.25.15]) by olra.theworths.org (Postfix) with ESMTP id A96C2431FAE for ; Fri, 30 Nov 2012 20:30:04 -0800 (PST) X-AuditID: 1209190f-b7fec6d00000090d-b7-50b987cb85af Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP id 8E.C8.02317.BC789B05; Fri, 30 Nov 2012 23:30:04 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id qB14U3SP015205; Fri, 30 Nov 2012 23:30:03 -0500 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qB14U1Bg021834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 30 Nov 2012 23:30:02 -0500 (EST) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) (envelope-from ) id 1TeeiG-0002DX-UY; Fri, 30 Nov 2012 23:30:01 -0500 Date: Fri, 30 Nov 2012 23:30:00 -0500 From: Austin Clements To: David Bremner Subject: Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines Message-ID: <20121201043000.GC4681@mit.edu> References: <1353792017-31459-1-git-send-email-david@tethera.net> <1353792017-31459-10-git-send-email-david@tethera.net> <87vcctiauq.fsf@qmul.ac.uk> <87pq2wgd15.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pq2wgd15.fsf@zancas.localnet> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42IR4hRV1j3TvjPAYKKvxY3WbkaL1XN5LK7f nMnswOyxc9Zddo9nq24xe2w59J45gDmKyyYlNSezLLVI3y6BK2PZkVtsBTNZK24d38nWwDiR pYuRk0NCwESi4f9XZghbTOLCvfVsXYxcHEIC+xglTp15zQ7hbGCU+Lv4ISOEc5FJ4sHMZqiy JYwSi3fdYQTpZxFQlbj35SAriM0moCGxbf9ysLgIUPzqtslsIDazgKvEjAu7mEBsYYEQiQmb W8FsXgFtiVl77jNBDN3NKPFo3wNWiISgxMmZT1ggmrUkbvx7CVTEAWRLSyz/xwES5hTQlbg+ eRfYLlEBFYkpJ7exTWAUmoWkexaS7lkI3QsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbpmujl ZpbopaaUbmIEh7ok/w7GbweVDjEKcDAq8fAmPNwRIMSaWFZcmXuIUZKDSUmU90zbzgAhvqT8 lMqMxOKM+KLSnNTiQ4wSHMxKIryyn4DKeVMSK6tSi/JhUtIcLErivFdTbvoLCaQnlqRmp6YW pBbBZGU4OJQkeBNAhgoWpaanVqRl5pQgpJk4OEGG8wAN5wWmBiHe4oLE3OLMdIj8KUZFKXHe GyDNAiCJjNI8uF5YKnrFKA70ijDvO5AqHmAag+t+BTSYCWjwm2XbQQaXJCKkpBoYRerSHaNu fTV0OjNFueu+RJRl8NOOAy3hARNicm/x/zOQ5xFbGjrtmIvaqh7VqjubWOvVMmNsf74u6fRt +az46KXZVsacD8wVD8+9vy5064d8p/reY5bSTXpbzQtOqExbsfTlt5K8PdVX9kbucWxTXms/ ecrb3SuXOB7WmzJ1b63b4clJEtOylFiKMxINtZiLihMB39mc4CADAAA= Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Dec 2012 04:30:05 -0000 Quoth David Bremner on Nov 29 at 8:17 pm: > Mark Walters writes: > > I don't know how freeze/thaw work but does it matter that you don't thaw > > when there is an error? > > My interpretation is that by not thawing before we destroy the message, > we are aborting the transaction, since the freeze/thaw information is > stored in the message structure. It is documented as forbidden to call > thaw _more_ times than freeze, but less is not explicitely mentioned. Yes, this should work. It smells a little hacky and I couldn't say if it was an intended use of the API, but it should work. Perhaps we should document it.