DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:to:cc:subject:in-reply-to:references:user-agent:date
	:message-id:mime-version:content-type;
	b=YKYNRTyGwwEx0v0AwBfVslvgAis2Ctw3u2HtEcUpLnv/u1jMUefwjHrj9Ndj4Suomo
	wnhWFJfTdNhatSjajFU8fi2t+Ipb6FxSJ24mAElO0p8bBraZNt4sOiTYZcMfcT4dZnBE
	BDvkLXlr4I1FZEink4XFVtOrQbwIfEIPD+GHI=
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Dima Kogan <notmuch@dima.secretsauce.net>
Subject: Re: [PATCH] Added C-up and C-down to cycle through previous searches
In-Reply-To: <20110604130732.5d28fb68@smart>
References: <1306659388-21809-1-git-send-email-notmuch@dima.secretsauce.net>
	<87vcwto5n3.fsf@gmail.com> <20110604130732.5d28fb68@smart>
User-Agent: Notmuch/0.5-227-g031f722 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 05 Jun 2011 11:28:59 +0400
Message-ID: <87fwnopwhw.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list

Hi Dima.

On Sat, 4 Jun 2011 13:07:32 -0700, Dima Kogan <notmuch@dima.secretsauce.net> wrote:
> > On Sun, 29 May 2011 20:04:00 +0400
> > Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> >
> > Hi Dima.
> > 
> > On Sun, 29 May 2011 01:56:28 -0700, notmuch@dima.secretsauce.net
> > wrote:
> > > From: Dima Kogan <dima@secretsauce.net>
> > > 
> > > ---
> > > 
> > >  Hi.
> > > 
> > >  I made a few improvements to the emacs UI. This patch allows the
> > > user to scroll through the most recent searches with C-up and
> > > C-down while in the search box.
> > > 
> > 
> > This sounds like a very nice improvement to me!  I just have one
> > concern: Why C-up and C-down?  I believe M-p and M-n would be more
> > natural for Emacs users (at least for me :)).
> > 
> > Also, I did not read the code and can not comment on it.  But notmuch
> > coding style is to use tabs for indentation.  I guess .dir-locals.el
> > should be improved to set coding style variables for all modes, not
> > just C.
> > 
> > Regards,
> >   Dmitry
> 
> Hi. I have a mild preference to C-up/down, but M-n/p is just fine also.
> As for the coding style, I've looked through that file
> (notmuch-hello.el), and it doesn't seem to have a consistent style as
> far as tabs/spaces go. I'm happy to change my patch to conform, but I
> don't know what I should be conforming to. Should I be tab-ing all
> indents, or just some?
> 

Notmuch uses a mix of 8 char width tabs and spaces.  First go tabs, then,
if you need indenting with more precision, spaces.  Look at the lines
your patch removes for an example.

Also, .dir-locals.el sets some variables to configure Emacs for Notmuch
coding style but only for c-mode.  You may set it by hand for lisp.

Regards,
  Dmitry