Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1EAAE429E3B for ; Mon, 16 Jan 2012 20:32:12 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CWwZ4ITFPXk7 for ; Mon, 16 Jan 2012 20:32:11 -0800 (PST) Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU [18.7.68.37]) by olra.theworths.org (Postfix) with ESMTP id 9ABD1429E35 for ; Mon, 16 Jan 2012 20:32:11 -0800 (PST) X-AuditID: 12074425-b7f4a6d0000008e0-b8-4f14f9cb4a0b Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP id A8.4F.02272.BC9F41F4; Mon, 16 Jan 2012 23:32:11 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q0H4WAY3023138; Mon, 16 Jan 2012 23:32:10 -0500 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0H4W928024242 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Mon, 16 Jan 2012 23:32:10 -0500 (EST) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1Rn0iG-0006Xj-8C; Mon, 16 Jan 2012 23:32:00 -0500 Date: Mon, 16 Jan 2012 23:32:00 -0500 From: Austin Clements To: Tomi Ollila Subject: Re: [PATCH 2/3] emacs: whitespace-cleanup and indent-region for emacs/*.el files Message-ID: <20120117043200.GJ16740@mit.edu> References: <1326704656-26102-1-git-send-email-tomi.ollila@iki.fi> <1326704656-26102-2-git-send-email-tomi.ollila@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1326704656-26102-2-git-send-email-tomi.ollila@iki.fi> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IRYrdT1z39U8Tf4EE/j8X1mzOZLd6snMfq wORx+OtCFo9nq24xBzBFcdmkpOZklqUW6dslcGV82DKHsWAOe8XLd/dYGhgfsXYxcnJICJhI rP95gh3CFpO4cG89WxcjF4eQwD5GiWNvGxghnA2MEg3tr9khnJNMEmua3jFBOEsYJU43PwHq 4eBgEVCV+LIsG2QUm4CGxLb9yxlBbBEBFYkHbevB1jELSEt8+93MBGILC0RLdPU/YAaxeQV0 JLYe6WGGmLmWUWLBhX+sEAlBiZMzn7BANGtJ3Pj3kglkF8ig5f84QMKcAs4SD29fYAOxRYF2 TTm5jW0Co9AsJN2zkHTPQuhewMi8ilE2JbdKNzcxM6c4NVm3ODkxLy+1SNdCLzezRC81pXQT IziwXVR3ME44pHSIUYCDUYmH96a3iL8Qa2JZcWXuIUZJDiYlUd6/P4BCfEn5KZUZicUZ8UWl OanFhxglOJiVRHgFfYByvCmJlVWpRfkwKWkOFiVxXk2td35CAumJJanZqakFqUUwWRkODiUJ 3v8gQwWLUtNTK9Iyc0oQ0kwcnCDDeYCGgy3mLS5IzC3OTIfIn2JUlBLnFQCmDiEBkERGaR5c LyzxvGIUB3pFmPcPSDsPMGnBdb8CGswENDinVQhkcEkiQkqqgdGgrHQ6q/uH56u3nD6e8yXK RlqmVOgJB+8Py8urT2aV7Z8y7Zvk1jrHR0+tJuTmuyw+0mm6WZkn9IrIv9eH7Iq5nrrPebRu b+cLn33++huU4i/OdJL8tGdF8J1jm4yrna8GtHNmfD94ZHI+u0P9/Ml/rgvwrL6b/zN1r+DH 6992PV3wa0nz+1OdSizFGYmGWsxFxYkA4tmo4xcDAAA= Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2012 04:32:12 -0000 Cleanup is the type of pain that should only be suffered once, so I'd be much happier with this if there was an accompanying git hook that prevented more mis-formatted code from slipping in. Quoth Tomi Ollila on Jan 16 at 11:04 am: > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el > index 00ed589..7b63348 100644 > --- a/emacs/notmuch-lib.el > +++ b/emacs/notmuch-lib.el > @@ -143,7 +143,7 @@ The result is a new function which does the same as FUN, except that > the first N arguments are fixed at the values with which this function > was called." > (lexical-let ((fun fun) (args1 args)) > - (lambda (&rest args2) (apply fun (append args1 args2)))))) > + (lambda (&rest args2) (apply fun (append args1 args2)))))) Ack. What happened here? This shows up in at least one other place, too. I'm betting you need to load cl in some form to get the indentation rule for lexical-let.