Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 76A41431FD7 for ; Sat, 15 Dec 2012 19:17:43 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R8e+7fMj1cx0 for ; Sat, 15 Dec 2012 19:17:42 -0800 (PST) Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU [18.7.68.36]) by olra.theworths.org (Postfix) with ESMTP id D1ACC431FBF for ; Sat, 15 Dec 2012 19:17:41 -0800 (PST) X-AuditID: 12074424-b7fe06d0000008f0-ca-50cd3d5545df Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP id 32.BE.02288.55D3DC05; Sat, 15 Dec 2012 22:17:41 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id qBG3HetP011431; Sat, 15 Dec 2012 22:17:40 -0500 Received: from drake.dyndns.org (209-6-116-242.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com [209.6.116.242]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qBG3HbGt012061 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Sat, 15 Dec 2012 22:17:39 -0500 (EST) Received: from amthrax by drake.dyndns.org with local (Exim 4.77) (envelope-from ) id 1Tk4jP-0007cH-SD; Sat, 15 Dec 2012 22:17:35 -0500 From: Austin Clements To: notmuch@notmuchmail.org Subject: [PATCH 7/7] emacs: Use --format-version for search, show, and reply Date: Sat, 15 Dec 2012 22:17:29 -0500 Message-Id: <1355627849-29099-8-git-send-email-amdragon@mit.edu> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1355627849-29099-1-git-send-email-amdragon@mit.edu> References: <1355627849-29099-1-git-send-email-amdragon@mit.edu> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsUixG6nrhtqezbAoPusqMXquTwW12/OZHZg 8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4Mr7PuM5YMF2q4vrK+8wNjK9Fuhg5OSQETCQe ffjDDGGLSVy4t56ti5GLQ0hgH6PEvPl3mSCcDYwSLQvesYFUCQk8YpK4ucgbIjGXUWLDyyWM IAk2AQ2JbfuXg9kiAtISO+/OZgWxmQUcJT7vXwTWLCzgI7FzzXGwGhYBVYmP5/eCreYVcJCY t/0lK8QZihLdzyaA1XMC9W7e8hNqsYPE7CNH2SYw8i9gZFjFKJuSW6Wbm5iZU5yarFucnJiX l1qka66Xm1mil5pSuokRHEguKjsYmw8pHWIU4GBU4uG1+HomQIg1say4MvcQoyQHk5Iob47l 2QAhvqT8lMqMxOKM+KLSnNTiQ4wSHMxKIrxJ84HKeVMSK6tSi/JhUtIcLErivNdTbvoLCaQn lqRmp6YWpBbBZGU4OJQkeJltgIYKFqWmp1akZeaUIKSZODhBhvMADVcGqeEtLkjMLc5Mh8if YlSUEueVAkkIgCQySvPgemGR/opRHOgVYV4NkCoeYJKA634FNJgJaPByG5Cri0sSEVJSDYxZ j8+w3zG2Lbnxik180iu+zaJOR1o3RB3/3Gt840ib9aYfrzdF/bpXcIk5wNye5Sx3nJH7riOW W6b2Ll6pvGSRnEDLW8cXhZZbev9u2D29ZYN74ZflfvsW/1V/tdgz+rHKp93ZlukbNpVs0FUU ebG85P+r+6mxORWfNH5N3JlRkGRdq80W1yGtxFKckWioxVxUnAgADg9pXs8CAAA= X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Dec 2012 03:17:43 -0000 --- emacs/notmuch-mua.el | 2 +- emacs/notmuch-query.el | 2 +- emacs/notmuch.el | 6 +++++- test/emacs | 2 +- test/emacs-show | 2 +- 5 files changed, 9 insertions(+), 5 deletions(-) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index ac2d29e..24eebff 100644 --- a/emacs/notmuch-mua.el +++ b/emacs/notmuch-mua.el @@ -146,7 +146,7 @@ list." (unless (bolp) (insert "\n"))) (defun notmuch-mua-reply (query-string &optional sender reply-all) - (let ((args '("reply" "--format=json")) + (let ((args '("reply" "--format=json" "--format-version=1")) reply original) (when notmuch-show-process-crypto diff --git a/emacs/notmuch-query.el b/emacs/notmuch-query.el index e7e3520..6e9f406 100644 --- a/emacs/notmuch-query.el +++ b/emacs/notmuch-query.el @@ -29,7 +29,7 @@ A thread is a forest or list of trees. A tree is a two element list where the first element is a message, and the second element is a possibly empty forest of replies. " - (let ((args '("show" "--format=json"))) + (let ((args '("show" "--format=json" "--format-version=1"))) (if notmuch-show-process-crypto (setq args (append args '("--decrypt")))) (setq args (append args search-terms)) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index b0fd387..63387a2 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -650,6 +650,10 @@ of the result." (insert "Incomplete search results (search process was killed).\n")) (when (eq status 'exit) (insert "End of search results.\n") + ;; For version mismatch, there's no point in + ;; showing the search buffer + (when (or (= exit-status 20) (= exit-status 21)) + (kill-buffer)) (condition-case nil (notmuch-check-async-exit-status proc msg) ;; Suppress the error signal since strange @@ -935,7 +939,7 @@ Other optional parameters are used as follows: (let ((proc (start-process "notmuch-search" buffer notmuch-command "search" - "--format=json" + "--format=json" "--format-version=1" (if oldest-first "--sort=oldest-first" "--sort=newest-first") diff --git a/test/emacs b/test/emacs index 5067d67..6b18968 100755 --- a/test/emacs +++ b/test/emacs @@ -873,7 +873,7 @@ This is output Error: Unexpected output from notmuch search: This is an error End of search results. -Error invoking notmuch. $PWD/notmuch_fail search --format=json --sort=newest-first tag:inbox exited with status 1." +Error invoking notmuch. $PWD/notmuch_fail search --format=json --format-version=1 --sort=newest-first tag:inbox exited with status 1." test_done diff --git a/test/emacs-show b/test/emacs-show index 40fab61..ebf530b 100755 --- a/test/emacs-show +++ b/test/emacs-show @@ -178,7 +178,7 @@ test_emacs "(let ((notmuch-command \"$PWD/notmuch_fail\")) (with-current-buffer \"*Notmuch errors*\" (test-output \"ERROR\")))" test_expect_equal "$(cat OUTPUT ERROR)" "\ -Error invoking notmuch. $PWD/notmuch_fail show --format=json --exclude=false ' * ' exited with status 1. +Error invoking notmuch. $PWD/notmuch_fail show --format=json --format-version=1 --exclude=false ' * ' exited with status 1. Error: This is an error Output: -- 1.7.10.4