Return-Path: <pieter@praet.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 1377B431FD0
	for <notmuch@notmuchmail.org>; Thu,  7 Jul 2011 01:07:06 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.7
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id uLdYuC+EiAYn for <notmuch@notmuchmail.org>;
	Thu,  7 Jul 2011 01:07:05 -0700 (PDT)
Received: from mail-wy0-f181.google.com (mail-wy0-f181.google.com
	[74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 2696E431FB6
	for <notmuch@notmuchmail.org>; Thu,  7 Jul 2011 01:07:05 -0700 (PDT)
Received: by wyh22 with SMTP id 22so507904wyh.26
	for <notmuch@notmuchmail.org>; Thu, 07 Jul 2011 01:07:03 -0700 (PDT)
Received: by 10.227.207.207 with SMTP id fz15mr426974wbb.76.1310026023751;
	Thu, 07 Jul 2011 01:07:03 -0700 (PDT)
Received: from localhost ([109.131.160.107])
	by mx.google.com with ESMTPS id b13sm6673393wbh.58.2011.07.07.01.07.02
	(version=TLSv1/SSLv3 cipher=OTHER);
	Thu, 07 Jul 2011 01:07:02 -0700 (PDT)
From: Pieter Praet <pieter@praet.org>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
	Daniel Schoepe <daniel.schoepe@googlemail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: Turn id:"<message-id>" elements into buttons
	for notmuch searches
In-Reply-To: <87r5624l3g.fsf@gmail.com>
References: <1309896760-378-1-git-send-email-daniel.schoepe@googlemail.com>
	<1309961881-28333-1-git-send-email-daniel.schoepe@googlemail.com>
	<1309961881-28333-2-git-send-email-daniel.schoepe@googlemail.com>
	<87r5624l3g.fsf@gmail.com>
User-Agent: Notmuch/0.5-331-g04cf689 (http://notmuchmail.org) Emacs/23.1.50.1
	(x86_64-pc-linux-gnu)
Date: Thu, 07 Jul 2011 10:07:00 +0200
Message-ID: <87sjqifra3.fsf@praet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jul 2011 08:07:06 -0000

On Thu, 07 Jul 2011 11:16:03 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Hi Daniel.
> 
> On Wed,  6 Jul 2011 16:18:01 +0200, Daniel Schoepe <daniel.schoepe@googlemail.com> wrote:
> > This fixes the minor annoyance that message ids were parsed as mail
> > addresses by goto-address-mode in notmuch-show buffers.
> 
> I did not try it yet but it looks like a nice feature.  Though I have
> some questions on the code below.
> 
> > ---
> >  emacs/notmuch-show.el |   24 +++++++++++++++++++++---
> >  1 files changed, 21 insertions(+), 3 deletions(-)
> > 
> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> > index f96743b..f924d17 100644
> > --- a/emacs/notmuch-show.el
> > +++ b/emacs/notmuch-show.el
> > @@ -27,6 +27,7 @@
> >  (require 'mm-decode)
> >  (require 'mailcap)
> >  (require 'icalendar)
> > +(require 'goto-addr)
> >  
> >  (require 'notmuch-lib)
> >  (require 'notmuch-query)
> > @@ -778,6 +779,24 @@ current buffer, if possible."
> >  (defvar notmuch-show-parent-buffer nil)
> >  (make-variable-buffer-local 'notmuch-show-parent-buffer)
> >  
> > +(defun notmuch-show-buttonise-links (start end)
> > +  "Buttonise URLs and mail addresses between START and END.
> > +
> > +This also turns id:\"<message id>\"-parts into buttons for
> > +a corresponding notmuch search."
> > +  (goto-address-fontify-region start end)
> > +  (save-excursion
> > +    (goto-char start)
> > +    (while (re-search-forward "id:\"[^ ]+\"" end t)
> > +      ;; remove the overlay created by goto-address-mode
> > +      (remove-overlays (match-beginning 0) (match-end 0) 'goto-address t)
> 
> Why do we need to remove `goto-address-mode' overlays if it is not
> enabled ((goto-address-mode t) is below is removed)?

Because those overlays got added by `goto-address-fontify-region'.

In fact, all `goto-address-mode' does, essentially, is call
  (jit-lock-register #'goto-address-fontify-region)

> > +      (make-text-button (match-beginning 0) (match-end 0)
> > +			'action `(lambda (arg)
> > +				   (notmuch-search ,(match-string-no-properties 0)))
> > +			'follow-link t
> > +			'help-echo "Mouse-1, RET: search for this message"
> > +			'face goto-address-mail-face))))
> > +
> >  ;;;###autoload
> >  (defun notmuch-show (thread-id &optional parent-buffer query-context buffer-name crypto-switch)
> >    "Run \"notmuch show\" with the given thread ID and display results.
> > @@ -822,9 +841,8 @@ function is used. "
> >  	  (notmuch-show-insert-forest
> >  	   (notmuch-query-get-threads basic-args))))
> >  
> > -      ;; Enable buttonisation of URLs and email addresses in the
> > -      ;; buffer.
> > -      (goto-address-mode t)
> 
> `goto-address-mode' creates buttons not only for email addresses but
> also for URLs.  Do we loose it now?

Nope, everything remains functional.

> Regards,
>   Dmitry
> 
> > +      (jit-lock-register #'notmuch-show-buttonise-links)
> > +
> >        ;; Act on visual lines rather than logical lines.
> >        (visual-line-mode t)
> >  
> > -- 
> > 1.7.5.4
> > 
> > _______________________________________________
> > notmuch mailing list
> > notmuch@notmuchmail.org
> > http://notmuchmail.org/mailman/listinfo/notmuch
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch


Peace

-- 
Pieter