Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4C369431FAF for ; Mon, 30 Apr 2012 04:53:59 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gKDuIqJOFgIy for ; Mon, 30 Apr 2012 04:53:58 -0700 (PDT) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id B5821431FAE for ; Mon, 30 Apr 2012 04:53:58 -0700 (PDT) Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.89.108] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1SOpAw-0004ba-8R; Mon, 30 Apr 2012 08:53:54 -0300 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1SOpAp-0004vR-Cc; Mon, 30 Apr 2012 08:53:47 -0300 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH] go: Update to the current notmuch_database_find_message API In-Reply-To: <1335649518-1970-1-git-send-email-amdragon@mit.edu> References: <1335649518-1970-1-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.12+152~g904a807 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Mon, 30 Apr 2012 08:53:47 -0300 Message-ID: <87lildph9w.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2012 11:53:59 -0000 Austin Clements writes: > The signature of notmuch_database_find_message was changed in 02a30767 > to report errors and the Go bindings were never updated. This brings > the Go bindings in sync with that change and at least makes them > compile with Go r60.3, the last release before Go 1. I don't have any easy way to test this, since the current versions in Debian are all based on Go 1. On the other hand I guess it doesn't make things worse. Anybody have any objections to this patch? In the long run we have to decide what to do about these bindings. Seb (or anyone else) are you interested in porting them to Go 1 and maintaining them? Otherwise it may be time to deprecate them. d