Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 822BA429E54 for ; Sat, 21 Jan 2012 22:56:59 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M9GAWPbOfrlH for ; Sat, 21 Jan 2012 22:56:59 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id F2220429E40 for ; Sat, 21 Jan 2012 22:56:58 -0800 (PST) Received: by wibhr12 with SMTP id hr12so1764507wib.26 for ; Sat, 21 Jan 2012 22:56:57 -0800 (PST) Received: by 10.180.106.202 with SMTP id gw10mr9019454wib.3.1327215417827; Sat, 21 Jan 2012 22:56:57 -0800 (PST) Received: from localhost ([109.131.97.13]) by mx.google.com with ESMTPS id gy6sm6346223wib.11.2012.01.21.22.56.56 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 21 Jan 2012 22:56:57 -0800 (PST) From: Pieter Praet To: Austin Clements Subject: Re: [PATCH 4/4] setup: prompt user for search.exclude_tags value In-Reply-To: <20120120041902.GV16740@mit.edu> References: <1326586654-16840-3-git-send-email-amdragon@mit.edu> <1327000744-25463-1-git-send-email-pieter@praet.org> <1327000744-25463-5-git-send-email-pieter@praet.org> <20120119194437.GP16740@mit.edu> <8762g7o0k4.fsf@praet.org> <20120120041902.GV16740@mit.edu> User-Agent: Notmuch/0.11+101~g94bf862 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Sun, 22 Jan 2012 07:55:05 +0100 Message-ID: <87ipk4446u.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jan 2012 06:56:59 -0000 On Thu, 19 Jan 2012 23:19:02 -0500, Austin Clements wrote: > [...] > Hah, okay. How about this as an initial minor refactoring of the code > for new.tags? > [...] Great, thanks! Would the following commit message be satisfactory? : #+begin_quote setup: move tag printing and parsing into separate functions * notmuch-setup.c (notmuch_setup_command): Break tag printing and response parsing out into separate functions called `print_tag_list' respectively `parse_tag_list', for reuse with the 'search.exclude_tags' option. #+end_quote (if not, please suggest an alternative; it'll be your name at the top) Thanks again! Peace -- Pieter