Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 9CAD6431FAE for ; Wed, 12 Sep 2012 14:27:35 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FnW6W4wn5pVX for ; Wed, 12 Sep 2012 14:27:35 -0700 (PDT) Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id E3428431FBF for ; Wed, 12 Sep 2012 14:27:34 -0700 (PDT) Received: by mail-lb0-f181.google.com with SMTP id gk1so1587473lbb.26 for ; Wed, 12 Sep 2012 14:27:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :in-reply-to:references:x-gm-message-state; bh=CRsQEVmz+lCMFcMBqGVZJDcpLVTQehRR7S9aFYOPOok=; b=ElnVV4I+gOlrSPgUFU/zHpp8h5FkC+vSBm+BT1w9uvPhPpnVbaTFmoyUO7p/QRlDB/ G7eyMfoaEjj523JFJxLEmKKklXKdX+bKCs7tFbAPB2Zc3MULOYVHxZxwah5fgGh2pUnz EpbpRpiiJ9XIlY7q3v/mtp4KzG6pF5VzdxqURayibhhtS6OGzahkzz435lXf5xaHJ21d FxyczpO07G71+S/2x2cYDGZYXz5TENeuzx+ikINOC1KS4KStCaTLJBRabd1V3BmkNHTv sWNT/9Tuz8KqXObfrNgO1CsfiyNgHMH+paociQbIstwdlyZrJtvRrVR3VYi0wYB1XZkN npAQ== Received: by 10.152.110.9 with SMTP id hw9mr15625135lab.55.1347485254531; Wed, 12 Sep 2012 14:27:34 -0700 (PDT) Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi. [80.223.81.27]) by mx.google.com with ESMTPS id d1sm5527603lbk.16.2012.09.12.14.27.32 (version=SSLv3 cipher=OTHER); Wed, 12 Sep 2012 14:27:33 -0700 (PDT) From: Jani Nikula To: notmuch@notmuchmail.org, David Bremner Subject: [PATCH v3 1/9] build: drop the -Wswitch-enum warning Date: Thu, 13 Sep 2012 00:27:18 +0300 Message-Id: <2990ebb63b865839c8d405163693482eb31b992f.1347484177.git.jani@nikula.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: In-Reply-To: References: X-Gm-Message-State: ALoCoQm5FetRNvOLJ4TVzefscWLaURcwftbJ+ZFSk3bkZcmGwlfy9GVlsUfWr/csVhb9HdpB38tt X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2012 21:27:35 -0000 -Wswitch-enum is a bit awkward if a switch statement is intended to handle just some of the named codes of an enumeration especially, and leave the rest to the default label. We already have -Wall, which enables -Wswitch by default, and per GCC documentation, "The only difference between -Wswitch and this option [-Wswitch-enum] is that this option gives a warning about an omitted enumeration code even if there is a default label." Drop -Wswitch-enum to not force listing all named codes of enumerations in switch statements that have a default label. --- This will be useful in the next patch. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index acb90a8..afa5c16 100755 --- a/configure +++ b/configure @@ -532,7 +532,7 @@ fi WARN_CXXFLAGS="" printf "Checking for available C++ compiler warning flags... " -for flag in -Wall -Wextra -Wwrite-strings -Wswitch-enum; do +for flag in -Wall -Wextra -Wwrite-strings; do if ${CC} $flag -o minimal minimal.c > /dev/null 2>&1 then WARN_CXXFLAGS="${WARN_CXXFLAGS}${WARN_CXXFLAGS:+ }${flag}" -- 1.7.9.5