Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 16C2C431FDC for ; Sun, 27 Oct 2013 05:29:52 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LiypuNEwYW82 for ; Sun, 27 Oct 2013 05:29:42 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 17F4F431FAF for ; Sun, 27 Oct 2013 05:29:42 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1VaPT8-0001gs-L0; Sun, 27 Oct 2013 09:29:22 -0300 Received: (nullmailer pid 29487 invoked by uid 1000); Sun, 27 Oct 2013 12:29:17 -0000 From: David Bremner To: Tomi Ollila , Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH 0/4] rename pick to tree In-Reply-To: References: <1382824928-3771-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.16+97~g6878b0b (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sun, 27 Oct 2013 09:29:17 -0300 Message-ID: <87k3gy523m.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Oct 2013 12:29:52 -0000 Tomi Ollila writes: > > LGTM. I will test (again) when the series posted to move this mainline > is submitted. > > Tomi > Looks OK to me as well. I did notice one warning about adding whitespace errors when applying patch 3/4. After staring at the patch a bit, I'm pretty sure that's the usual problem that the test data actually has trailing whitespace in it, so nothing to worry about. d