To: Mark Walters <m.walters@qmul.ac.uk>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects.
In-Reply-To: <874nvh5tro.fsf@qmul.ac.uk>
References: <1327496913-4946-1-git-send-email-dme@dme.org>
	<1327499314-7887-1-git-send-email-dme@dme.org>
	<1327499314-7887-4-git-send-email-dme@dme.org>
	<874nvh5tro.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.11+122~g97bdcf6 (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Fri, 27 Jan 2012 10:28:56 +0000
Message-ID: <cunk44djv6f.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Fri, 27 Jan 2012 10:23:07 +0000, Mark Walters <m.walters@qmul.ac.uk> wro=
te:
> I am very much not a lisp expert

Me neither, so please do continue to review stuff.

> The patch 1/3 seems to set the show buffer line to *[No Subject]* where
> it used to be just [No Subject]. (I have no preference: I just wasn't
> sure if that was intentional.

There was inconsistency before, now the buffer name always has the
surrounding *s.

> Patch 3/3:
> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> > index e6a5b31..c602b3e 100644
> > --- a/emacs/notmuch-show.el
> > +++ b/emacs/notmuch-show.el
> > @@ -985,7 +985,7 @@ buffer."
> >        (notmuch-show-next-open-message))
> >=20=20
> >      ;; Set the header line to the subject of the first open message.
> > -    (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-=
subject)))
> > +    (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-=
pretty-subject)))
> >=20=20
> >      (notmuch-show-mark-read)))
> >=20=20
> > @@ -1216,6 +1216,9 @@ Some useful entries are:
> >  (defun notmuch-show-get-depth ()
> >    (notmuch-show-get-prop :depth))
> >=20=20
> > +(defun notmuch-show-get-pretty-subject ()
> > +  (notmuch-prettify-subject (notmuch-show-get-subject)))
> > +
> >  (defun notmuch-show-set-tags (tags)
> >    "Set the tags of the current message."
> >    (notmuch-show-set-prop :tags tags)
>=20
> As far as I can see notmuch-show-get-pretty-subject is only called once
> so I wondered why you bothered with a new function. But as I say I have
> almost zero lisp experience so no feel for lisp style.

Just mirroring the existing structure really.
`notmuch-show-get-<something>' to access details of the message. I've no
strong preference.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8ifGgACgkQaezQq/BJZRYw6QCePHN9bKWfow9xhUJf2uV28e3P
QSYAn3h7fgZsneL1bMrZaClnd7maxmUR
=mV95
-----END PGP SIGNATURE-----
--=-=-=--