From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Mike Kelly <pioto@pioto.org>, notmuch@notmuchmail.org
Subject: Re: FreeBSD Support Patches
In-Reply-To: <1337953411-21000-1-git-send-email-pioto@pioto.org>
References: <1337953411-21000-1-git-send-email-pioto@pioto.org>
User-Agent: Notmuch/0.13+30~g6d44c5a (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Fri, 25 May 2012 18:15:57 +0400
Message-ID: <87ipfktkgy.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

Hi Mike.

Mike Kelly <pioto@pioto.org> writes:

> Hi,
>
> These patches add some changes necessary for a clean build on FreeBSD,
> and for most of the tests to pass.
>
> Also mixed in are a few patches to disable emacs tests when you don't
> have emacs, along with tests that depend upon emacs. I could split those
> off onto a separate branch if required.
>

Why do we need to explicitly declare Emacs dependency for tests?  There
should be no need for it.  We have "implicit" dependencies which are
declared once (see test_declare_external_prereq calls at the end of
test-lib.sh) and are automatically handled when a test tries to use a
missing binary.  Explicit dependencies are hard to maintain (e.g. your
patch adds explicit emacs dependency for crypto test but misses gpg).
With rare exceptions we should not use explicit dependencies.

Regards,
  Dmitry

> You can find the latest version of these patches on my github repo's
> fbsd-support branch:
>
>   https://github.com/pioto/notmuch/compare/master...fbsd-support 
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch