Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7C471431FB6 for ; Fri, 7 Dec 2012 05:14:43 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sNDxBBEFBp0s for ; Fri, 7 Dec 2012 05:14:43 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 24372431FAE for ; Fri, 7 Dec 2012 05:14:43 -0800 (PST) Received: from fctnnbsc30w-142167090129.dhcp-dynamic.fibreop.nb.bellaliant.net ([142.167.90.129] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TgxlJ-0003xh-UA; Fri, 07 Dec 2012 09:14:42 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1TgxlE-0005Hd-Dh; Fri, 07 Dec 2012 09:14:36 -0400 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH] test: Fix UTF-8 JSON tests in Python 3 In-Reply-To: <1354634654-9564-1-git-send-email-amdragon@mit.edu> References: <87d2yp27zu.fsf@nexoid.at> <1354634654-9564-1-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.14+75~g984212d (http://notmuchmail.org) Emacs/24.1.1 (x86_64-pc-linux-gnu) Date: Fri, 07 Dec 2012 09:14:36 -0400 Message-ID: <87r4n2t35v.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Dec 2012 13:14:43 -0000 Austin Clements writes: > test_expect_equal_json uses json.tool from the system Python. While > Python 2 wasn't picky about the encoding of stdin, Python 3 decodes > stdin strictly according to the environment. Since we set LC_ALL=C > for the tests, Python 3's json.tool was assuming stdin would be in > ASCII and aborting when it couldn't decode the UTF-8 characters from > some of the JSON tests. This patch sets the PYTHONIOENCODING > environment variable to utf-8 when invoking json.tool to override > Python's default encoding choice. This looks sensible; marking ready d