From: Mark Walters <markwalters1009@gmail.com>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: add support for stashing the thread id in show
	view
In-Reply-To: <1354834085-8225-1-git-send-email-jani@nikula.org>
References: <87mwxqhkqu.fsf@qmul.ac.uk>
	<1354834085-8225-1-git-send-email-jani@nikula.org>
User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1
	(i486-pc-linux-gnu)
Date: Fri, 07 Dec 2012 07:53:18 +0000
Message-ID: <87wqwu5mdt.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

Jani Nikula <jani@nikula.org> writes:

> Add a prefix argument to notmuch-show-stash-message-id to stash thread
> id instead of message id.


LGTM +1

Mark


> ---
>  emacs/notmuch-show.el |   14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 4d6c014..658a2be 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1901,10 +1901,16 @@ thread from search."
>    (interactive)
>    (notmuch-common-do-stash (notmuch-show-get-from)))
>  
> -(defun notmuch-show-stash-message-id ()
> -  "Copy id: query matching the current message to kill-ring."
> -  (interactive)
> -  (notmuch-common-do-stash (notmuch-show-get-message-id)))
> +(defun notmuch-show-stash-message-id (&optional stash-thread-id)
> +  "Copy id: query matching the current message to kill-ring.
> +
> +If invoked with a prefix argument (or STASH-THREAD-ID is
> +non-nil), copy thread: query matching the current thread to
> +kill-ring."
> +  (interactive "P")
> +  (if stash-thread-id
> +      (notmuch-common-do-stash notmuch-show-thread-id)
> +    (notmuch-common-do-stash (notmuch-show-get-message-id))))
>  
>  (defun notmuch-show-stash-message-id-stripped ()
>    "Copy message ID of current message (sans `id:' prefix) to kill-ring."
> -- 
> 1.7.10.4