Message-ID: <4ecf5a6f.84b8340a.1db5.045f@mx.google.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To: David Bremner <david@tethera.net>,
	Antoine Amarilli <antoine.amarilli@ens.fr>, notmuch@notmuchmail.org
From: Patrick Totzke <patricktotzke@googlemail.com>
In-Reply-To: <8762i98pnh.fsf@zancas.localnet>
References: <20111106221554.GA23240@clipper.ens.fr>
	<8762i98pnh.fsf@zancas.localnet>
Subject: =?utf-8?q?Re=3A_python-notmuch_decoding_error_on_a_message?=
Date: Fri, 25 Nov 2011 09:04:06 +0000
Precedence: list

Silly question: how do i get Antoine's msg stup into notmuch? i tried
using pythons mailbox lib to add this string to one of my mailboxes, which =
works fine.
but upon `notmuch new` I get something along the lines of "skipped non-mail=
 file $myfile"..

back to the topic:
I find it hichgly suprising that this decode fails because one can easily d=
o sth like:

```
>>>'=3D?utf-8?B?M+ht?=3D =3D?utf-8?Q?e?=3D'.decode('UTF-8')
u'=3D?utf-8?B?M+ht?=3D =3D?utf-8?Q?e?=3D'
```
So the actual string should not be the problem. Apparently,
the string as its stored in the index is not plain ascii anymore, which it =
was in the msg.
I thought notmuch stores exacctly what it gets?

Apart from this, I'd recommend replacing all decodes to unicode objects
by a subroutine that does the following:
If a global property notmuch.DEBUG is set to true: decode as is,
which will raise these exceptions upon errors
else: use .decode('UTF-8', errors=3D'ignore').

In case the mail is not malformed, it will not contain any non-ascii symbol=
s whatsoever,
so both ways should work. If you happen to deal with a malformed mail, you'=
d get
the problematic symbols omitted (beware of this when doing cryptostuff).

what do you think?
/p


Quoting David Bremner (2011-11-24 16:13:22)
>On Sun, 6 Nov 2011 23:15:54 +0100, Antoine Amarilli <antoine.amarilli@ens.=
fr> wrote:
>> Hello,
>> =

>> The attached message makes python-notmuch crash when trying to access it=
 (see
>> attached log).
>> =

>> I don't know if the encoding of Subject is valid or not, but it would pr=
obably
>> be better anyway to ignore decoding errors and return some approximation=
 of
>> Subject instead of failing like this.
>> =

>
>I get a set of critical errors about forgetting to call g_type_init.
>
>We actually call g_type_init in the CLI now, thanks to =

>   =

>   id:"1311625989-97755-1-git-send-email-aaronecay@gmail.com"
>
>but it sounds like this probably needs to be called either in libnotmuch
>or in the bindings. =

>
>For what it is worth this message decodes fine in the CLI
>
>d
>_______________________________________________
>notmuch mailing list
>notmuch@notmuchmail.org
>http://notmuchmail.org/mailman/listinfo/notmuch