Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 00E1B431FAF
	for <notmuch@notmuchmail.org>; Wed,  8 Feb 2012 23:54:32 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id I3WCIyph6GVw for <notmuch@notmuchmail.org>;
	Wed,  8 Feb 2012 23:54:31 -0800 (PST)
Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
	by olra.theworths.org (Postfix) with ESMTP id 474C1431FAE
	for <notmuch@notmuchmail.org>; Wed,  8 Feb 2012 23:54:31 -0800 (PST)
Received: by guru.guru-group.fi (Postfix, from userid 501)
	id 7C17468055; Thu,  9 Feb 2012 09:54:30 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: cleanup and simplify `notmuch-show-archive-thread'
	and related functions
In-Reply-To: <1328719731-13402-1-git-send-email-dmitry.kurochkin@gmail.com>
References: <1328719731-13402-1-git-send-email-dmitry.kurochkin@gmail.com>
User-Agent: Notmuch/0.11.1+164~g6619341 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Thu, 09 Feb 2012 09:54:30 +0200
Message-ID: <m21uq4saq1.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Feb 2012 07:54:32 -0000

On Wed,  8 Feb 2012 20:48:51 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Recent changes in notmuch-show tagging introduced some code
> duplication.  The patch cleanups and simplifies
> `notmuch-show-archive-thread' function by using
> `notmuch-show-tag-all', no longer used function are removed.  After
> the change, `notmuch-show-archive-thread' function becomes symmetric
> with `notmuch-show-archive-message'.
> 
> A side effect of these changes is that `notmuch-show-archive-thread'
> no longer calls "notmuch tag" for each message in the thread.
> ---

+1, works fine, is fast

Tomi