Return-Path: <pieter@praet.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 6A868429E21
	for <notmuch@notmuchmail.org>; Sat, 16 Apr 2011 06:26:20 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id PmanMvkfFiCp for <notmuch@notmuchmail.org>;
	Sat, 16 Apr 2011 06:26:16 -0700 (PDT)
Received: from mail-wy0-f181.google.com (mail-wy0-f181.google.com
	[74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id DF85C431FB6
	for <notmuch@notmuchmail.org>; Sat, 16 Apr 2011 06:26:15 -0700 (PDT)
Received: by wyi11 with SMTP id 11so3983061wyi.26
	for <notmuch@notmuchmail.org>; Sat, 16 Apr 2011 06:26:14 -0700 (PDT)
Received: by 10.227.9.196 with SMTP id m4mr3138573wbm.196.1302960374185;
	Sat, 16 Apr 2011 06:26:14 -0700 (PDT)
Received: from localhost (99.28-240-81.adsl-dyn.isp.belgacom.be
 [81.240.28.99])	by mx.google.com with ESMTPS id
 w12sm2170748wby.7.2011.04.16.06.26.12	(version=TLSv1/SSLv3 cipher=OTHER);
	Sat, 16 Apr 2011 06:26:13 -0700 (PDT)
From: Pieter Praet <pieter@praet.org>
To: Kan-Ru Chen <kanru@kanru.info>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] emacs: notmuch-hello: Add "n" and "p" to mod map
In-Reply-To: <1280195325-9066-3-git-send-email-kanru@kanru.info>
References: <1280195325-9066-1-git-send-email-kanru@kanru.info>
	<1280195325-9066-3-git-send-email-kanru@kanru.info>
User-Agent: Notmuch/0.5-86-g4875299 (http://notmuchmail.org) Emacs/23.1.50.1
	(x86_64-pc-linux-gnu)
Date: Sat, 16 Apr 2011 15:26:11 +0200
Message-ID:
 <87lizatjik.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Apr 2011 13:26:21 -0000

On Tue, 27 Jul 2010 09:48:45 +0800, Kan-Ru Chen <kanru@kanru.info> wrote:
> Bind "n" to widget-forward and "p" to widget-backward to unify the
> interface since other notmuch major mode also accept "n" and "p" to
> navigation.
> ---
>  emacs/notmuch-hello.el |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 6ef03bb..7def241 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -294,6 +294,8 @@ should be. Returns a cons cell `(tags-per-line width)'."
>      (define-key map "=" 'notmuch-hello-update)
>      (define-key map "G" 'notmuch-hello-poll-and-update)
>      (define-key map (kbd "<C-tab>") 'widget-backward)
> +    (define-key map "n" 'widget-forward)
> +    (define-key map "p" 'widget-backward)
>      (define-key map "m" 'notmuch-mua-mail)
>      (define-key map "s" 'notmuch-hello-goto-search)
>      map)
> -- 
> 1.7.1
> 
> 


Sounds logical in theory, but in practice, you'll soon get stuck
spamming "nnnnnpppnwtf" in the search field.

That, and TAB/S-TAB feels more natural.

Thanks to this patch, however, I did stumble upon a bug:
id:"87ei522v4t.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me"

Peace

-Pieter