Date: Sat, 10 May 2014 08:18:33 -0700
From: "W. Trevor King" <wking@tremily.us>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH] doc: Fix parallel build of roff files
Message-ID: <20140510151833.GR28634@odin.tremily.us>
References: <1397766897-14475-1-git-send-email-amdragon@mit.edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="xi/AxZ9U2VfEekdX"
Content-Disposition: inline
In-Reply-To: <1397766897-14475-1-git-send-email-amdragon@mit.edu>
OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
	url=http://tremily.us/pubkey.txt
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: notmuch@notmuchmail.org
Precedence: list


--xi/AxZ9U2VfEekdX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 17, 2014 at 04:34:57PM -0400, Austin Clements wrote:
> +$(DOCBUILDDIR)/.roff.stamp: ${MAN_RST_FILES}
>  ifeq ($(HAVE_SPHINX),1)
>  	$(SPHINXBUILD) -b man $(ALLSPHINXOPTS) $(DOCBUILDDIR)/man
>  	for section in 1 5 7; do \
> @@ -48,6 +54,7 @@ else
>  	@echo "Fatal: build dependency fail."
>  	@false
>  endif
> +	touch ${MAN_ROFF_FILES} $@

I'm poking around in the Makefile, and don't understand why we're
touching ${MAN_ROFF_FILES} here.  Either they were just created by
Sphinx/rst2man, or we died with the @false.  I doubt Sphinx or
prerst2man.py are intelligent enough to not clobber the roff files if
their content hasn't changed, but I don't see a point in explicitly
bumping timestamps either.

I think I'll drop the ${MAN_ROFF_FILES} as part of the patch I'm
working on, but let me know if I'm just missing something.

Cheers,
Trevor

--=20
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy


--xi/AxZ9U2VfEekdX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJTbkNGAAoJEKKfehoaNkbtLPMP/0YksUEaIFoUAdyTbh3iTSKz
OpUNdned/u+hyVLto8uU5/OzXCHCmS987k/nzz2TlxdRTs9JEuGNeSR6b5K6CVWp
GC2DZOGWBwUcpbyBc2LW1lLeFZdYc+MAYL6h6s5QuNwqL7TufWZEacr8Jw+tX1N2
S0lHxd5Hj8H5QxxaMYy/MjscVdO09RKreW7w2LpZgYtIGXCmAtrZo3Ktm11gU2hJ
AGeE4Z11+D3Ze97Z6SlEtXiO1c1FACwwdVaFAlApysPPwd9tK34ueZ7qhhk4iSsc
/PaQmmbWDhPgEOt+hFTZuFqmHAJje8OVPkBRT6I6d21/XigvE7AyDRpRQrBmywVp
X0nBnRSMMssCiCrFI8hhkrynETQWOBROdDTrV7ehSNEerQAATEw7Sc2jFjui6akD
K8VpURUL7ppBLzhG2sZ5Hc6vE2Uj4mLW0WmTbAsjel6VRJRyFsudDfrcX5Zvh2Q6
CYSFg/vIUaqWYM3xfpxPob1AGuvV38OAtt0g65KPShli4b0Z32/TrUUGEACVTGRP
Yd6j/t3AD6om13Gfe/VaEwKIjQ6Ccs4d6dI1JEe1YMtEysnfb2Xe7l8pg+J8SA/u
1TabxD+aVvbXg/6zZ80gI8ezsPDRCUsmZnV1Oqq3MHhVCuTuky0+d+rUqkCA6jTO
TFHXK3LMZnTfvyIOSeao
=9M7o
-----END PGP SIGNATURE-----

--xi/AxZ9U2VfEekdX--