Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 81C43431FB6 for ; Thu, 2 Dec 2010 07:13:29 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id adZYFe1y5R2s for ; Thu, 2 Dec 2010 07:13:28 -0800 (PST) Received: from heal.cauterized.net (heal.cauterized.net [89.140.131.167]) by olra.theworths.org (Postfix) with ESMTP id 34EDE431FB5 for ; Thu, 2 Dec 2010 07:13:28 -0800 (PST) Received: from localhost (pb-d-128-141-44-137.cern.ch [128.141.44.137]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by heal.cauterized.net (Postfix) with ESMTPSA id 63DD07023A7D for ; Thu, 2 Dec 2010 16:13:26 +0100 (CET) Date: Thu, 2 Dec 2010 16:13:25 +0100 From: Ruben Pollan To: notmuch@notmuchmail.org Subject: Re: [PATCH] test: change "#!/bin/bash" to "#!/usr/bin/env bash" enhances portability Message-ID: <20101202151325.GI1775@blackspot> References: <1291235272-16335-1-git-send-email-joel.borggren.franck@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gTY1JhLGodeuSBqf" Content-Disposition: inline In-Reply-To: <1291235272-16335-1-git-send-email-joel.borggren.franck@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2010 15:13:29 -0000 --gTY1JhLGodeuSBqf Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 21:27, Wed 01 Dec 10, Joel Borggr=E9n-Franck wrote: > From: Joel Borggr=E9n-Franck >=20 > Change #!/bin/bash at start of tests to "#!/usr/bin/env bash". That way > systems running on bash < 4 can prepend bash >=3D 4 to path before > running the tests. Is there any reason to use bash? Is the test system dependent to any key fe= ature of bash? Not every system has bash installed. To have a dependency on bash just for development I think is not a big issue. But if it don't requires any big ef= fort I think will be better to have it more generic. --=20 Rub=E9n Poll=E1n | jabber:meskio@jabber.org -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-= =3D-=3D-=3D-=3D-=3D- Nos vamos a Croatan. --gTY1JhLGodeuSBqf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkz3t5UACgkQGKOQ92SwNMJ30gCfTC0mkrpZWtMzuPs54GYuPEkT vOQAnj3Lns4zkcQGv2oQhIKAKy7GFyJK =8b/X -----END PGP SIGNATURE----- --gTY1JhLGodeuSBqf--